Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document optimization.nodeEnv #2139

Merged
merged 6 commits into from
May 15, 2018
Merged

Document optimization.nodeEnv #2139

merged 6 commits into from
May 15, 2018

Conversation

EugeneHlushko
Copy link
Member

Fixes #2138
Tackles one off #1968

@EugeneHlushko
Copy link
Member Author

Hi @jeremenichelli if thats possible to review and merge this one to unblock further work on the section for me?


`string` `bool: false`

Tells webpack to set `process.env.NODE_ENV` to a given string value. `optimization.nodeEnv` uses [DefinePlugin](/plugins/define-plugin/) unless set to `false`. `optimization.nodeEnv` __defaults__ to [mode](/concepts/mode/) if set, else falls back to `"production"`. Possible values:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you put Possible values on a new line? It will help users while scanning the options through the article.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, good idea

@montogeek
Copy link
Member

Thanks!

@montogeek montogeek merged commit d14b3f3 into master May 15, 2018
@EugeneHlushko EugeneHlushko deleted the issues/2138 branch May 15, 2018 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants