Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs optimization #2271

Merged
merged 3 commits into from
Jun 15, 2018
Merged

Docs optimization #2271

merged 3 commits into from
Jun 15, 2018

Conversation

EugeneHlushko
Copy link
Member

@EugeneHlushko EugeneHlushko commented Jun 15, 2018

  • adds namedChunks and namedModules options to the docs

Tackles two off #1968

@@ -100,19 +100,41 @@ module.exports = {

Use the `optimization.noEmitOnErrors` to skip the emitting phase whenever there are errors while compiling. This ensures that no erroring assets are emitted. The `emitted` flag in the stats is `false` for all assets.

__webpack.config.js__
W> If you are using webpack [CLI](/api/cli/), the webpack process will not exit with an error code while this plugin is enabled. If you want webpack to "fail" when using the CLI, please check out the [`bail` option](/api/cli/#advanced-options).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which plugin? Better name it, than writing this plugin..

Copy link
Member

@Legends Legends left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@montogeek montogeek merged commit 1bc333a into master Jun 15, 2018
@montogeek
Copy link
Member

Thank you!

@montogeek montogeek deleted the docs-optimization branch June 15, 2018 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants