-
Notifications
You must be signed in to change notification settings - Fork 303
Mark several privacy sandbox features as discouraged #3526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
captainbrosset
merged 12 commits into
web-platform-dx:main
from
ddbeck:deprecate-privacy-sandbox
Dec 18, 2025
Merged
Changes from 11 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
87f820e
Deprecate `shared-storage`
ddbeck 4bc8cdd
Break out `requestStorageAccessFor()` into a separate, deprecated
ddbeck c2ff39d
Deprecate `attribution-reporting`
ddbeck 3276862
Deprecate `topics`
ddbeck 2039c10
Merge branch 'main' into deprecate-privacy-sandbox
ddbeck 1391305
Guard against missing descriptions and discouraged reasons
ddbeck 79a82af
Add reasons and removal dates
ddbeck 712cffa
Merge branch 'main' into deprecate-privacy-sandbox
ddbeck c7e9327
Discourage `shared-storage-locks`
ddbeck 0dcb2a3
Apply suggestions from code review
captainbrosset 2a5030f
Apply suggestions from code review
captainbrosset 1a09bc9
Update features/shared-storage.yml
captainbrosset File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| name: Related website sets | ||
| description: Related website sets declares relationships between sites so the browser allows cookie and storage access between them through methods such as `document.requestStorageAccessFor()`. | ||
| spec: | ||
| - https://wicg.github.io/first-party-sets/ | ||
| - https://privacycg.github.io/requestStorageAccessFor/ | ||
| discouraged: | ||
| removal_date: 2026-06-01 # Chrome 150 | ||
| reason: Following the announcement that Chrome will maintain its current approach to third-party cookies, Chrome decided to withdraw certain Privacy Sandbox features including the related website sets. | ||
| according_to: | ||
| - https://groups.google.com/a/chromium.org/g/blink-dev/c/V-wPXyoruac | ||
| - https://chromestatus.com/feature/5162221567082496 | ||
| - https://chromestatus.com/feature/5194473869017088 | ||
|
captainbrosset marked this conversation as resolved.
|
||
| compat_features: | ||
| - api.Document.requestStorageAccessFor | ||
| - api.Permissions.permission_top-level-storage-access | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,23 @@ | ||
| # Generated from: related-website-sets.yml | ||
| # Do not edit this file by hand. Edit the source file instead! | ||
|
|
||
| status: | ||
| baseline: false | ||
| support: | ||
| chrome: "119" | ||
| chrome_android: "120" | ||
| edge: "119" | ||
| compat_features: | ||
| # baseline: false | ||
| # support: | ||
| # chrome: "113" | ||
| # chrome_android: "120" | ||
| # edge: "113" | ||
| - api.Permissions.permission_top-level-storage-access | ||
|
|
||
| # baseline: false | ||
| # support: | ||
| # chrome: "119" | ||
| # chrome_android: "119" | ||
| # edge: "119" | ||
| - api.Document.requestStorageAccessFor |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,11 @@ import remarkParse from "remark-parse"; | |
| import remarkRehype from "remark-rehype"; | ||
| import { unified } from "unified"; | ||
|
|
||
| export function convertMarkdown(markdown: string) { | ||
| export function convertMarkdown(markdown: unknown) { | ||
| if (typeof markdown !== "string") { | ||
| throw new Error(`${markdown} is not a string!`); | ||
| } | ||
|
|
||
| const mdTree = unified().use(remarkParse).parse(markdown); | ||
|
Comment on lines
-8
to
13
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remark stringifies anything, apparently, converting |
||
| const htmlTree = unified().use(remarkRehype).runSync(mdTree); | ||
| const text = hastTreeToString(htmlTree); | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.