-
Notifications
You must be signed in to change notification settings - Fork 217
Mark several privacy sandbox features as discouraged #3526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ddbeck
wants to merge
9
commits into
web-platform-dx:main
Choose a base branch
from
ddbeck:deprecate-privacy-sandbox
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7957bb3 to
e5ff69e
Compare
e5ff69e to
3276862
Compare
ddbeck
commented
Dec 11, 2025
ddbeck
commented
Dec 12, 2025
Comment on lines
-8
to
13
| export function convertMarkdown(markdown: string) { | ||
| export function convertMarkdown(markdown: unknown) { | ||
| if (typeof markdown !== "string") { | ||
| throw new Error(`${markdown} is not a string!`); | ||
| } | ||
|
|
||
| const mdTree = unified().use(remarkParse).parse(markdown); |
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remark stringifies anything, apparently, converting undefined to the string "undefined". This throw ought to stop us from "successfully" converting missing fields to strings.
Collaborator
Author
|
This is becoming more urgent as BCD has started marking the keys as deprecated: |
3426b70 to
c7e9327
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature definition
Creating or defining new features or groups of features.
tools and infrastructure
Project internal tooling, such as linters, GitHub Actions, or repo settings
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Google is deprecating a number of privacy sandbox features I think all of them are single implementer, so they'll qualify for deprecation in BCD and end up here too. No reason not to get ahead a little. Features affected:
attribution-reportingprotected-audience(see Addprotected-audiencefeature #2635)storage-access(break outrequestStorageAccessFor())shared-storagetopicsThere are questions about Edge on some of these, so there's some more research to be done on this.
via mdn/browser-compat-data#28417, where there's a nice list of links to intent-to-deprecate messages.