fix: inlined export invalid syntax comment

[ahabhgk]

Summary

fix #12631

Related links

Checklist

• Tests updated (or not required).
• Documentation updated (or not required).

[netlify]

✅ Deploy Preview for rspack canceled.

Name	Link
🔨 Latest commit	993e6d3
🔍 Latest deploy log	https://app.netlify.com/projects/rspack/deploys/695fa0c2616bd600081018a9

[Copilot]

Pull request overview

This PR fixes a bug where inlined export comments were placed outside parentheses, creating invalid JavaScript syntax in certain contexts (especially division operations). The fix moves comments inside the parentheses.

Key changes:

• Modified EvaluatedInlinableValue::render() and InlinedUsedName::render() to accept a comment parameter and place it inside parentheses: (/* comment */value) instead of /* comment */ (value)
• Updated all call sites across the codebase to pass the appropriate comment string
• Added a new test case to verify the fix works correctly for division expressions

Reviewed changes

Copilot reviewed 35 out of 35 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
crates/rspack_core/src/exports/utils.rs	Core fix: Modified render methods to accept comment parameter and place it inside parentheses
crates/rspack_core/src/concatenated_module.rs	Updated all inlined value render calls to use new API with comment parameter
crates/rspack_core/src/runtime_template.rs	Updated inlined value render call to use new API
crates/rspack_core/src/exports/export_info_getter.rs	Updated render call with empty comment for rename info
crates/rspack_plugin_esm_library/src/link.rs	Updated multiple inlined value render calls with appropriate comments
crates/rspack_plugin_javascript/src/dependency/esm/esm_export_imported_specifier_dependency.rs	Updated to generate proper comment for inlined exports
crates/rspack_plugin_javascript/src/dependency/commonjs/common_js_*.rs	Updated CommonJS dependency handlers to use new render API
crates/rspack_plugin_library/src/*.rs	Updated library plugin render calls with empty comments
tests/rspack-test/configCases/inline-const/generated-syntax/*	New test case verifying fix for division expression syntax
tests/rspack-test/configCases/rsdoctor/assets/rspack.config.js	Updated expected file sizes (1 byte reduction per file)
All other test snapshot files	Updated snapshots to reflect new comment placement inside parentheses

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[github-actions]

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary

Project	Total Size	Change
react-10k	5.7 MB	0
react-1k	825.4 KB	0
react-5k	2.7 MB	0
rome	984.3 KB	0
ui-components	2.1 MB	0

Generated by Rsdoctor GitHub Action

[github-actions]

📦 Binary Size-limit

Comparing 993e6d3 to refactor: unify artifact clear logic (#12677) by hardfist

🎉 Size decreased by 768bytes from 47.87MB to 47.87MB (⬇️0.00%)

[codspeed-hq]

Merging this PR will not alter performance

Summary

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark¹

---

_{Comparing fix-inline-comment (993e6d3) with main (70ffab9)}

Footnotes

1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩