feat: support MF share treeshake #12250

2heal1 · 2025-11-20T07:30:54Z

Summary

Support shared tree shaking .

It support two modes: runtime-infer | server-calc to satisfy different demands.

View this discusstion for more details .

Checklist

Tests updated (or not required).
Documentation updated (or not required).

netlify · 2025-11-20T07:30:59Z

✅ Deploy Preview for rspack canceled.

Name	Link
🔨 Latest commit	`3282b3d`
🔍 Latest deploy log	https://app.netlify.com/projects/rspack/deploys/6970d7bea0561d00084d0bd2

github-actions · 2025-11-20T07:41:29Z

📦 Binary Size-limit

Comparing b33c235 to refactor: improve runtime module macro (#12941) by harpsealjs

❌ Size increased by 216.38KB from 48.34MB to 48.55MB (⬆️0.44%)

codspeed-hq · 2025-11-20T09:08:31Z

CodSpeed Performance Report

Merging this PR will not alter performance

_{Comparing feat/shared-treeshake (b33c235) with main (bacc120)}

Summary

✅ 16 untouched benchmarks
⏩ 1 skipped benchmark¹

1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports. ↩

…shaking fix incorrect module name in shared config and test cases change async process_module to sync using block_on for better performance update shared exports optimization to handle side effects properly

github-actions · 2025-12-09T09:39:38Z

Rsdoctor Bundle Diff Analysis

Found 5 projects in monorepo, 0 projects with changes.

📊 Quick Summary

Project	Total Size	Change
react-10k	5.7 MB	0
react-1k	825.4 KB	0
react-5k	2.7 MB	0
rome	984.2 KB	0
ui-components	2.2 MB	0

Generated by Rsdoctor GitHub Action

…ent tree-shaking Add fallback for undefined moduleToHandlerMapping in shared container entry Include additional plugins in filter list and prevent tree-shaking of shared modules by adding console logs when collectShared is true

…rategy

refactor(node_binding): remove redundant exports in wasi files

Copilot

Pull request overview

This PR implements tree-shaking support for shared dependencies in Module Federation, allowing for more efficient bundle sizes by eliminating unused exports from shared modules. The implementation spans both Rust (core functionality) and JavaScript/TypeScript (API and runtime).

Changes:

Adds tree-shaking configuration options to shared dependencies with two modes: runtime-infer and server-calc
Implements plugins for collecting and optimizing shared module exports
Updates runtime to support dynamic loading of tree-shaken shared modules
Adds comprehensive test coverage for the new functionality

Reviewed changes

Copilot reviewed 84 out of 124 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
website/docs/{en,zh}/plugins/webpack/tree-shaking-shared-plugin.mdx	New documentation for TreeShakingSharedPlugin
website/docs/{en,zh}/plugins/webpack/module-federation-plugin.mdx	Documentation for new tree-shaking options
packages/rspack/src/sharing/*.ts	TypeScript implementation of tree-shaking plugins
packages/rspack/src/container/*.ts	Updates to Module Federation plugin
packages/rspack/src/runtime/moduleFederationDefaultRuntime.js	Runtime support for tree-shaking
crates/rspack_plugin_mf/src/sharing/*.rs	Rust implementation of tree-shaking logic
crates/rspack_plugin_mf/src/container/*.rs	Container entry module changes
crates/rspack_core/src/*.rs	Core type additions and dependency handling
tests/rspack-test/configCases/sharing/*	Comprehensive test cases
pnpm-lock.yaml, package.json	Dependency version updates

Files not reviewed (1)

pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

tests/rspack-test/configCases/sharing/reshake-share/index.js

tests/rspack-test/configCases/container-1-5/tree-shaking-shared-infer-mode/rspack.config.js

tests/rspack-test/configCases/container-1-5/tree-shaking-shared-server-mode/rspack.config.js

Add GitHub action for continuous benchmarking with CodSpeed. The action supports multiple measurement modes and instruments, including MongoDB instrumentation and caching for faster runs. Includes validation for required inputs and custom runner installation.

crates/rspack_plugin_javascript/src/plugin/flag_dependency_usage_plugin.rs

ahabhgk · 2026-02-04T08:11:46Z

crates/rspack_binding_api/src/raw_options/raw_builtins/mod.rs

+          .into();
+        plugins.push(CollectSharedEntryPlugin::new(options).boxed())
+      }
+      BuiltinPluginName::SharedContainerPlugin => {


What is SharedContainerPlugin, can this merge into ContainerPlugin with an additional option?

While both plugins share the underlying ContainerEntryDependency , I don't think they should be merged or reused at the plugin level due to their distinct responsibilities and configurations:

Different Responsibilities : ContainerPlugin is a general-purpose plugin for exposing multiple modules ( exposes ), whereas SharedContainerPlugin is specialized for wrapping a single shared dependency (like react ) into an isolated container, typically used with IndependentSharedPlugin .

Configuration Structure : ContainerPlugin handles a complex list of exposes map and enhanced mode settings. SharedContainerPlugin focuses on a single request and version without the concept of exposes . Reusing ContainerPlugin here would require awkward parameter conversion (e.g., faking request as an exposes entry), which increases complexity.

Runtime Behavior : They inject different RuntimeModule s ( ExposeRuntimeModule vs ShareContainerRuntimeModule ). Merging them would introduce unnecessary branching logic.
I believe reusing them at the Dependency level (as they currently do) is the correct level of abstraction.

crates/rspack_plugin_javascript/src/dependency/esm/esm_import_specifier_dependency.rs

Optimize the optimize_dependencies hook to reduce lock contention: - Batch collect module info with single read lock instead of N times - Batch apply mutations with single write lock instead of N times - Pre-compute runtime referenced exports outside of write locks This fixes performance regression introduced by #12250 where each module iteration acquired separate read/write locks on module_graph. Related: #12250

chenjiahan · 2026-02-10T14:04:10Z

packages/rspack/package.json

  },
  "peerDependencies": {
-    "@module-federation/runtime-tools": ">=0.22.0",
+    "@module-federation/runtime-tools": "0.24.1",


@2heal1 Why use a fixed version here? Should we include ^0.24.1 and ^2.0.0

chenjiahan · 2026-02-10T14:06:26Z

packages/rspack/src/sharing/IndependentSharedPlugin.ts

+    'SharedUsedExportsOptimizerPlugin',
+    'HtmlWebpackPlugin',
+    'HtmlRspackPlugin',
+    'RsbuildHtmlPlugin',


Hardcoding an Rsbuild internal plugin name to @rspack/core doesn't seem like good practice...

This plugin class name isn't a public API and is unstable.

github-actions bot added the release: feature release: feature related release(mr only) label Nov 20, 2025

2heal1 force-pushed the feat/shared-treeshake branch from a55f482 to 4bccd0f Compare November 20, 2025 07:44

2heal1 temporarily deployed to npm-canary November 20, 2025 09:22 — with GitHub Actions Inactive

2heal1 force-pushed the feat/shared-treeshake branch from 43683b8 to b49c5b5 Compare November 21, 2025 08:59

2heal1 temporarily deployed to npm-canary November 21, 2025 11:20 — with GitHub Actions Inactive

2heal1 force-pushed the feat/shared-treeshake branch from 635668b to 98a6db7 Compare November 24, 2025 03:32

2heal1 temporarily deployed to npm-canary November 24, 2025 11:22 — with GitHub Actions Inactive

2heal1 temporarily deployed to npm-canary November 25, 2025 03:28 — with GitHub Actions Inactive

2heal1 force-pushed the feat/shared-treeshake branch from 09e0e3f to 611139b Compare November 25, 2025 09:48

2heal1 temporarily deployed to npm-canary November 25, 2025 11:39 — with GitHub Actions Inactive

2heal1 force-pushed the feat/shared-treeshake branch from a052b96 to 2219929 Compare December 9, 2025 08:14

feat: treeshake share

3c0a94e

2heal1 force-pushed the feat/shared-treeshake branch from 2219929 to 3c0a94e Compare December 9, 2025 08:28

fix(module-federation): correct shared module name and optimize tree …

e27a87e

…shaking fix incorrect module name in shared config and test cases change async process_module to sync using block_on for better performance update shared exports optimization to handle side effects properly

2heal1 temporarily deployed to npm-canary December 9, 2025 10:05 — with GitHub Actions Inactive

feat(module-federation): add treeshakeSharedExcludedPlugins option

f7e6adf

2heal1 temporarily deployed to npm-canary December 11, 2025 13:10 — with GitHub Actions Inactive

chore: add watchRun

4c2435c

2heal1 temporarily deployed to npm-canary December 12, 2025 07:38 — with GitHub Actions Inactive

2heal1 temporarily deployed to npm-canary December 15, 2025 03:37 — with GitHub Actions Inactive

test(container-1-5): add ui-lib package for treeshake shared infer st…

c976e7b

…rategy

2heal1 temporarily deployed to npm-canary December 15, 2025 09:48 — with GitHub Actions Inactive

2heal1 added 3 commits December 22, 2025 15:10

chore: merge main

8a6a7d9

fix(shared_used_exports): handle scoped package names in shared exports

c38ded8

refactor(node_binding): remove redundant exports in wasi files

chore: update critical file

22d591c

Copilot AI reviewed Feb 3, 2026

View reviewed changes

2heal1 added 11 commits February 3, 2026 16:27

chore: fix cargo clippy

9fbc69c

Merge branch 'main' into feat/shared-treeshake

d7c6a31

Merge branch 'main' into feat/shared-treeshake

f71ce01

chore: bump

7ef330a

chore: merge main

132f049

Merge branch 'main' into feat/shared-treeshake

a0e1c67

Merge branch 'main' into feat/shared-treeshake

5ac3ca1

workflow: revert ci

44fe169

chore: revert cacahe implementation

247bd99

Merge branch 'main' into feat/shared-treeshake

2db5635

ahabhgk reviewed Feb 4, 2026

View reviewed changes

2heal1 added 10 commits February 4, 2026 16:21

chore: merge main

9de1210

chore: use get_referenced_exports

d62d2a5

Merge branch 'main' into feat/shared-treeshake

5742f68

chore: revert esm depnedency change

0aa547b

Merge branch 'main' into feat/shared-treeshake

f59d807

chore: revert esm_import_specifier_dependency change

26185ce

Merge branch 'main' into feat/shared-treeshake

615e164

Merge branch 'main' into feat/shared-treeshake

e541b7a

Merge branch 'main' into feat/shared-treeshake

b4e2ed3

refactor(mf): simplify runtime module implementations

b33c235

ahabhgk approved these changes Feb 5, 2026

View reviewed changes

hardfist merged commit cd402a1 into main Feb 5, 2026
47 of 49 checks passed

hardfist deleted the feat/shared-treeshake branch February 5, 2026 05:14

hardfist mentioned this pull request Feb 5, 2026

perf: try fix mf performance regression #12958

Merged

2 tasks

chenjiahan reviewed Feb 10, 2026

View reviewed changes

Uh oh!

feat: support MF share treeshake #12250

feat: support MF share treeshake #12250

Uh oh!

Conversation

2heal1 commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Related links

Checklist

Uh oh!

netlify bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for rspack canceled.

Uh oh!

github-actions bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📦 Binary Size-limit

Uh oh!

codspeed-hq bot commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Performance Report

Merging this PR will not alter performance

Summary

Footnotes

Uh oh!

github-actions bot commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rsdoctor Bundle Diff Analysis

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ahabhgk Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

2heal1 Feb 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

chenjiahan Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

chenjiahan Feb 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

2heal1 commented Nov 20, 2025 •

edited

Loading

netlify bot commented Nov 20, 2025 •

edited

Loading

github-actions bot commented Nov 20, 2025 •

edited

Loading

codspeed-hq bot commented Nov 20, 2025 •

edited

Loading

github-actions bot commented Dec 9, 2025 •

edited

Loading