-
-
Notifications
You must be signed in to change notification settings - Fork 760
feat(rstest): add preserveNewUrl option to keep new URL untouched #12632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for rspack ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary of ChangesHello @fi3ework, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the RstestPlugin by introducing a Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds a preserveNewUrl option to the RstestPlugin to keep new URL("*.wasm", import.meta.url) expressions untouched in the output, which is useful for testing scenarios where the original URL construction needs to be preserved (e.g., when using fs.readFile() with WASM paths in tests).
Key Changes:
- Added
preserveNewUrlboolean option (default:false) to RstestPlugin configuration - Implemented custom URL dependency template that skips transformation for
.wasmfiles when the option is enabled - Non-wasm assets continue to be processed normally through the standard URL dependency template
Reviewed changes
Copilot reviewed 9 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
crates/rspack_plugin_rstest/src/url_dependency.rs |
New module implementing RstestUrlDependencyTemplate that conditionally preserves wasm URL expressions |
crates/rspack_plugin_rstest/src/plugin.rs |
Updated to conditionally register the custom URL dependency template when preserve_new_url is enabled |
crates/rspack_plugin_rstest/src/lib.rs |
Added the new url_dependency module to the plugin exports |
crates/rspack_binding_api/src/rstest.rs |
Added preserve_new_url field to the plugin options with default value of false |
crates/node_binding/napi-binding.d.ts |
Added TypeScript type definition for the new optional preserveNewUrl field |
tests/rspack-test/configCases/rstest/new-url-wasm/* |
New test case validating that wasm URLs are preserved while non-wasm URLs are transformed normally |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
📦 Binary Size-limit
❌ Size increased by 3.13KB from 47.87MB to 47.87MB (⬆️0.01%) |
Rsdoctor Bundle Diff AnalysisFound 5 projects in monorepo, 0 projects with changes. 📊 Quick Summary
Generated by Rsdoctor GitHub Action |
CodSpeed Performance ReportMerging #12632 will not alter performanceComparing Summary
Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a preserveNewUrl option to the RstestPlugin to prevent new URL("*.wasm", ...) expressions from being processed, which is useful in testing environments. The implementation is clean, adding a new dependency template to conditionally handle URL dependencies, and is well-supported by new tests. My feedback includes a minor cleanup to remove an unused import.
|
@copilot fix the failed CI. |
…2632) * feat(rstest): add preserveNewUrl option to keep new URL untouched * fix: format Rust code with rustfmt
* react_server_components transform * fix: ReactServerComponents * ReactServerComponentPlugin * fix: rspack_loader_swc Wtf8Atom * feat: ReactServerComponentPlugin * feat: ServerEntryModules * exports_info * temp * feat: import with layer * fix: before pass * export ReactServerComponentsPlugin * ServerEntries * feat: client_entry_loader * feat: client compiler * feat: traverse_modules * feat: ClientReferenceManifestPlugin * feat: react_server_components layer * fix ReactClientPlugin * fix: ClientReferenceManifestPlugin * refactor: rename to ReactServerPlugin * remove eager * feat: collect entry css files * feat: use server-entry * server actions transform * feat: action_entry_loader * collect server_actions * temp * manifest-loader * RscManifestRuntimeModule * fix: build_server_consumer_module_map * fix: entry_css_files * feat: record_entry_js_files * refactor: entry_css_files * fix: entry js files and entry css files should concat prefix * remove unused code * chore: rename loader and plugin * fix: Coordinator * fix: entry js files prevent hot-module files from being included * clear PLUGIN_STATE_BY_COMPILER_ID * feat: add_include client action * feat: prev_server_component_hashs * fix: client compiler not rebuild right * export RSC_LAYERS_NAMES * fix: remove import with layer * refactor: rsc_pass * refactor: rsc_meta * refactor: to_module_ref * fix: cargo clippy * fix: lint and spelling * api changed * refactor: use get_module_resource * fix: ts type * fix: compiler watching * feat: check should_inject_ssr_modules * fix: only invalidate client after proxying client watching * fix: client module chunks should exclude hot module replacement js * chore: rename coordinator mod * fix: collect_component_info_from_entry_denendency * fix: panic in create_client_entries * fix: browser action * rm ACTION_BROWSER layer * fix: use atomic ref * refactor client plugin * fix: should handle compile failed * chore: rm unused print * fix: use server-entry mix use client * feat: ensureServerActions * fix: RSC_HOT_RELOADER * refactor: create_client_entries * fix: encryptActionBoundArgs and decryptActionBoundArgs * fix: should collect entry css files in after_process_assets hook * fix: with concat module * chore(deps): update patch npm dependencies (#12647) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update patch crates (#12646) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: run ci/eco-ci/eco-benchmark on v2 branch (#12650) * fix: report error when access module_graph in loader (#12639) * fix: report error when access module_graph in loader * Apply suggestions from code review Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> * feat(rstest): add preserveNewUrl option to keep new URL untouched (#12632) * feat(rstest): add preserveNewUrl option to keep new URL untouched * fix: format Rust code with rustfmt * fix(lint): enable @typescript-eslint/await-thenable rule (#12644) * fix(lint): enable await-thenable rule and fix violation - Enable @typescript-eslint/await-thenable rule (off -> error) - Remove unnecessary await on syncTraceEvent() which returns void * Update rslint.json --------- Co-authored-by: neverland <[email protected]> * fix: cargo clippy * refactor: rm RSC_HOT_RELOADER runtime module * fix: lint check * refactor: rename RscPluginLayers * warp rsc in namespace * fix: rsc client plugin * fix: cargo fmt * add next.js Copyright * fix: user can change fileDependencies in done hook * chore: add comments * fix: cargo fmt * rm ustr dependencies --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: harpsealjs <[email protected]> Co-authored-by: hardfist <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Max <[email protected]> Co-authored-by: Tu Shaokun <[email protected]> Co-authored-by: neverland <[email protected]>
* feat: treeshake share * fix(module-federation): correct shared module name and optimize tree shaking fix incorrect module name in shared config and test cases change async process_module to sync using block_on for better performance update shared exports optimization to handle side effects properly * feat(module-federation): add treeshakeSharedExcludedPlugins option * chore: add watchRun * fix(shared-modules): handle undefined moduleToHandlerMapping and prevent tree-shaking Add fallback for undefined moduleToHandlerMapping in shared container entry Include additional plugins in filter list and prevent tree-shaking of shared modules by adding console logs when collectShared is true * test(container-1-5): add ui-lib package for treeshake shared infer strategy * fix(shared_used_exports): handle scoped package names in shared exports refactor(node_binding): remove redundant exports in wasi files * chore: update critical file * feat(module-federation): add target and plugins to build info for treeshaking Add target and plugins fields to build info when treeshaking is enabled in module federation. Also rename 'reshake' to 'reShake' for consistency across the codebase. These changes support better treeshaking analysis and configuration. * docs: update field * feat: add treeshakeSharedPlugins * fix: lint * fix: lockfile * fix: lint * chore: rename config * chore(deps): update patch npm dependencies (#12647) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update patch crates (#12646) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore: run ci/eco-ci/eco-benchmark on v2 branch (#12650) * fix: report error when access module_graph in loader (#12639) * fix: report error when access module_graph in loader * Apply suggestions from code review Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Copilot <[email protected]> * feat(rstest): add preserveNewUrl option to keep new URL untouched (#12632) * feat(rstest): add preserveNewUrl option to keep new URL untouched * fix: format Rust code with rustfmt * fix(lint): enable @typescript-eslint/await-thenable rule (#12644) * fix(lint): enable await-thenable rule and fix violation - Enable @typescript-eslint/await-thenable rule (off -> error) - Remove unnecessary await on syncTraceEvent() which returns void * Update rslint.json --------- Co-authored-by: neverland <[email protected]> * refactor: afterCodeGeneration hook use read only compilation ref (#12655) * fix(lint): enable @typescript-eslint/require-await rule (#12664) fix(lint): enable require-await rule and fix violations - Enable @typescript-eslint/require-await rule (off -> error) - FileSystem.ts: Add missing return for Promise, remove async - SubresourceIntegrityPlugin.ts: Use Promise.resolve() instead of async - browser/service.ts: Remove async from function that only throws - loader-runner/worker.ts: Remove async from .then/.catch callbacks * chore(deps): update github-actions (#12645) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * fix(lint): enable @typescript-eslint/return-await rule (#12665) * refactor: make compilation readonly for runtimeModule hook (#12670) * feat: add constructor name for JS runtime modules (#12673) feat: add constructor name for JS runtime module * fix: incremental rebuild no code generation entry panic (#12643) * fix: incremental rebuild bug * add test case * fix: ci * refactor: unify artifact clear logic (#12677) * refactor: use DerfOpt's take/replace assist artifact mutation (#12659) * refactor: remove Default trait of DerefOption * refactor: `replace` is better than `insert` * feat: rspack_cacheable context expose project root (#12685) * feat: rspack_cacheable context expose project root * fix: comment * feat: rspack_cacheable add portable path & portable string (#12688) feat: add portable path & portable string * fix: inlined export invalid syntax comment (#12681) * feat: add `requireAlias` option to control require variable renaming (#12686) * feat: add requireRename option to control require variable renaming * Update packages/rspack/src/config/types.ts Co-authored-by: Copilot <[email protected]> * Update tests/rspack-test/configCases/parsing/renaming-disabled/index.js Co-authored-by: Copilot <[email protected]> * rename * rename --------- Co-authored-by: Copilot <[email protected]> * fix(test): flaky test due to calling toJSON while hot updating (#12694) * feat: impl `sync_trace` for `logger` tracing layer (#12687) * Sync node events for logger tracing * Align sync_trace * Remove unless info * Cargo shear * Use one writer * Filter JavaScript * Handle timestamps * Clippy * Clippy * feat: add warning when requireAlias is disabled (#12700) * refactor: rename tree shaking field name * revert: "feat: add warning when requireAlias is disabled" (#12702) Revert "feat: add warning when requireAlias is disabled (#12700)" This reverts commit eb5635c. * feat: use rspack-vue-loader to support Vue hot update (#12698) feat: use rspack-vue-loader to support hotupdate * chore: update artificat * chore: replace async processAssets hooks with sync versions * fix: `environments.importMetaDirnameAndFilename` not work (#12708) fix: `environments.importMetaDirnameAndFilename` should work * fix: dynamic entry panic when disable build cache (#12696) * fix(context-replacement): only apply changes when regex matches (#12657) fix(ContextReplacementPlugin): only apply changes when regex matches The plugin was applying transformations (recursive, regExp, critical) to all require.context() calls regardless of whether the configured regex pattern matched the request. This fix ensures all transformations only apply when the regex successfully matches. Closes #12656 * docs: add missed doc * fix: remove ueless dep * chore: update lock file * fix(mf): handle missing chunk gracefully and improve expose chunk name logic (#12709) * fix(type): runtimeModule.source (#12713) * fix(type): runtimeModule.source * fix: lint * fix: lint * chore: release 1.7.2 (#12710) Release 0.7.2 [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] [email protected] Generated by cargo-workspaces * chore(deps): update dependency @rspack/plugin-react-refresh to ^1.6.0 (#12718) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency @shikijs/transformers to ^3.21.0 (#12719) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update patch crates (#12716) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * test: skip recover-from-error/delete-file in watchCases (#12726) * feat: support portable cache and disable by default (#12680) * feat: support portable cache * feat: disable portable cache by default * fix: rename reShake to secondaryTreeShaking * chore: update artificat * test: use Rstest projects to define tests (#12729) * test: use rstest projects * test: update * test: output.module * test: update * chore(deps): update patch npm dependencies (#12717) * chore(deps): update patch npm dependencies * fix: downgrade MF --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: neverland <[email protected]> * refactor: move pass into separate folder and driven by run_passes (#12735) * chore: add rspack_passes.md * refactor: move pass into separate folder and drive by run_passes * chore: use function * refactor: move more into run_passes * chore: fix stats logging * chore: fix stats.logging * refactor(lazy-compilation): use POST request to transfer ids of active modules (#12678) * refactor: use post transfer module ids * test: skip lazy active method * test: add lazy post request help * test: add large module id container * test: add case introduction * refactor: remove about controller * test: we are using post method now * refactor: rename * fix body parser (vibe-kanban 09797829) 1. 如果其他中间件一个解析好了body,并挂载在req.body 上的花就直直接使用 req.body 2. packages/rspack/src/builtin-plugin/lazy-compilation/middleware.ts body 解析的时候不能简单的使用 string 的拼接,需要考虑多字节符号的截断的问题。 * refactor read module ids from body (vibe-kanban a7874ac1) packages/rspack/src/builtin-plugin/lazy-compilation/middleware.ts 当req.body 非空时,直接假body中时一组 module ids,如果没有 body 自行拼接完,之后也 parse json string,返回 module ids 数组 * refactor: downgrading to lower web api * test: ✅ add lazy compilation active cors cases * chore: update test case doc * fix: we all need cors header no matter is simple request or not * refactor:delete cors header setting * refactor: set cors header should set by user * Update packages/rspack/hot/lazy-compilation-web.js Co-authored-by: neverland <[email protected]> * test: fix case name * chore: api-extract update * fix: memory leak of requst listeners * refactor: remove event source handle logic * fix: jsdom XMLHTTPRequets need strict cors header * refactor: node lazy compilation client use post too --------- Co-authored-by: neverland <[email protected]> * refactor: move logger into pass and reorg some passes (#12742) * refactor: move logger into pass and reorg some passes * chore: fix bench check * chore(lint): bump @rslint/core to 0.2.0 and enable default-param-last rule (#12746) * chore(deps): bump @rslint/core to 0.2.0 and update rslint.json * fix(lint): enable @typescript-eslint/default-param-last rule * test: support filter test by absolute path (#12749) * test: support filter test by absolute path * Update packages/rspack-test-tools/src/helper/directory.ts Co-authored-by: Copilot <[email protected]> * Update packages/rspack-test-tools/src/helper/directory.ts Co-authored-by: Copilot <[email protected]> * Update tests/rspack-test/Cache.test.js Co-authored-by: Copilot <[email protected]> * fix: lint * docs: update -t --------- Co-authored-by: Copilot <[email protected]> * refactor: use newtype for alias artifact (#12754) * chore: bump `swc_core` from 54 to 55 (#12758) * chore: bump swc * chore: bump swc exp * chore: cargo codegen * refactor: move all artifacts together (#12755) * chore: limit threads for codspeed benchmark (#12763) Limit threads * chore(deps): update dependency cspell to ^9.6.0 (#12768) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency emnapi to ^1.8.1 (#12769) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * chore(deps): update dependency memfs to v4.53.0 (#12770) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> * refactor: use compilation readonly ref in codegen optimization hook (#12743) * refactor: use compilation readonly ref in code generation optimization hook * chore: debug bench ci * fix: 🐛 use offical codseed action * Debug ci * Remove debugger * Limit tokio and rayon worker threads * Revert "Limit tokio and rayon worker threads" This reverts commit 10fe6ac. * Update crates/rspack_plugin_progress/src/lib.rs Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: CPunisher <[email protected]> Co-authored-by: Copilot <[email protected]> * fix(browser): update worker format and add e2e test (#12747) * fix: remove lazyCompilationMiddleware * chore: change worker entry to iife * chore: add e2e test * chore: fix format * fix: add await for e2e * fix: remove unused imports * chore: fix ci yml * chore: fix ci WASM env injection * fix: update shared global name * perf: reuse container plugin * chore: fix merge conflict * chore: use official version and update docs * chore: fix cargo clippy * chore: bump * workflow: revert ci * ci: add CodSpeed performance analysis action Add GitHub action for continuous benchmarking with CodSpeed. The action supports multiple measurement modes and instruments, including MongoDB instrumentation and caching for faster runs. Includes validation for required inputs and custom runner installation. * chore: revert cacahe implementation * chore: use get_referenced_exports * chore: revert esm depnedency change * chore: revert esm_import_specifier_dependency change * refactor(mf): simplify runtime module implementations --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: harpsealjs <[email protected]> Co-authored-by: hardfist <[email protected]> Co-authored-by: Copilot <[email protected]> Co-authored-by: Max <[email protected]> Co-authored-by: Tu Shaokun <[email protected]> Co-authored-by: neverland <[email protected]> Co-authored-by: pshu <[email protected]> Co-authored-by: jinrui <[email protected]> Co-authored-by: Gengkun <[email protected]> Co-authored-by: CPunisher <[email protected]> Co-authored-by: 9aoy <[email protected]> Co-authored-by: neverland <[email protected]> Co-authored-by: Cong-Cong Pan <[email protected]> Co-authored-by: Agney Menon <[email protected]> Co-authored-by: Fy <[email protected]> Co-authored-by: senze.fan <[email protected]>
Summary
Add
preserveNewUrloption to RstestPlugin (default:false)When enabled, matched new URL expression like
new URL("*.wasm", import.meta.url)expressions are preserved in output, this is useful in testing case, especially for following code:Non-matched assets continue to be processed normally
Related links
Checklist