-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validate constant expressions for global/offsets initialization #372
Conversation
1db5e85
to
eab7cdd
Compare
8154174
to
a7dff89
Compare
Codecov Report
@@ Coverage Diff @@
## master #372 +/- ##
=======================================
Coverage 99.32% 99.33%
=======================================
Files 42 42
Lines 12834 12902 +68
=======================================
+ Hits 12748 12816 +68
Misses 86 86 |
ae03f96
to
edb0e64
Compare
9b915e1
to
ee7a549
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, with two nits:
- Once you move a test to validation_test.cpp in the same commit where functional change is. Other time this is done in two separate commits.
- I'd rather use
global.get
, notglobal_get
in comments and error messages.
704e2cf
to
8b2a96b
Compare
I made separate commits with the moves, now there're more test commits.
Changed. |
Will review this later today. |
346cf4f
to
6e745d0
Compare
Rebased. |
6e745d0
to
56df4e8
Compare
Rebased. |
56df4e8
to
eda3aa9
Compare
eda3aa9
to
7ab30da
Compare
7ab30da
to
6f1e9bb
Compare
Reordered commits. |
Replaced by individual PRs. |
More validation for number of instructions in const expr will be added in #377
I will squash test commits before merging.