Validate number of instructions in constant expression #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
force-pushed
the
validate-constexpr-count
branch
3 times, most recently
from
e71632e to
54615db
Compare
Codecov Report
@@ Coverage Diff @@
## master #377 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 43 43
Lines 13027 13048 +21
=======================================
+ Hits 12918 12939 +21
Misses 109 109 |
axic
reviewed
Jun 8, 2020
chfast
reviewed
Jun 8, 2020
gumb0
force-pushed
the
validate-constexpr-count
branch
from
54615db to
2fbdac5
Compare
gumb0
force-pushed
the
validate-constexpr-count
branch
from
2fbdac5 to
6df94a8
Compare
gumb0
force-pushed
the
validate-constexpr-count
branch
from
6df94a8 to
c189718
Compare
axic
approved these changes
Jun 26, 2020
chfast
approved these changes
Jun 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #372Based on #397
According to validation spec, result of constant expression has type
[t]for global initializer[i32]for offset initializersThis implies that constant expression can have only single
*.constorglobal.getinstruction.Spec tests check that with expected error "type mismatch": https://github.com/WebAssembly/spec/blob/60facfbb74cbb9f818258bbb07d02c581352e592/test/core/global.wast#L281-L289