Validate constant expressions in globals initializers #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axic
reviewed
Jun 26, 2020
gumb0
force-pushed
the
validate-globals-init-offset
branch
from
bb82453 to
093bab0
Compare
axic
reviewed
Jun 26, 2020
axic
reviewed
Jun 26, 2020
gumb0
force-pushed
the
validate-globals-init-offset
branch
from
093bab0 to
c4671d2
Compare
axic
approved these changes
Jun 26, 2020
Codecov Report
@@ Coverage Diff @@
## master #394 +/- ##
=======================================
Coverage 99.16% 99.16%
=======================================
Files 43 43
Lines 12980 13009 +29
=======================================
+ Hits 12871 12900 +29
Misses 109 109 |
gumb0
force-pushed
the
validate-globals-init-offset
branch
from
c4671d2 to
753492e
Compare
|
Rebased. |
axic
force-pushed
the
validate-globals-init-offset
branch
from
753492e to
cba8659
Compare
|
Rebased. @gumb0 please check. |
axic
force-pushed
the
validate-globals-init-offset
branch
2 times, most recently
from
4698532 to
f804f04
Compare
gumb0
force-pushed
the
validate-globals-init-offset
branch
from
f804f04 to
27f5cf3
Compare
gumb0
force-pushed
the
validate-globals-init-offset
branch
from
27f5cf3 to
bd75054
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First part of #372