Unnamed packages #4532
Merged
Unnamed packages #4532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this makes a bunch of potentially breaking changes, needs thorough review and testing.
if a package does not have name, it falls back to it's webc hash. This does mean that you need a webc hash to actually generate the PackageId.
because of the recent fs work done by @maminrayej on wasmerio/piirta/crates/webc, we can now remove this hack.
we can just switch the paths when developing, but should revert to the patch git branch style when pushing. This will make it easier to coordinate on stuff.
* Change PackageId to support both named and unnamed package * Update the package resolver logic with unnamed package support * Update the "package download" command
syrusakbary
reviewed
Apr 24, 2024
syrusakbary
reviewed
Apr 24, 2024
There was a problem hiding this comment.
@maminrayej will fix the linting and request flags, and package tests
@xdoardo will fix the cli tests
This was referenced Apr 24, 2024
…nto unnamed-packages
…named-packages # Conflicts: # lib/cli/src/commands/app/create.rs # lib/cli/src/commands/app/deploy.rs
syrusakbary
approved these changes
Apr 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds support for unnamed packages, which are packages that don't have a
name.
This is useful for packages that are not meant to be used by other
people/packages but are used to deploy apps.