Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wasmer_api::query::fetch_webc_package #4598

Closed
theduke opened this issue Apr 24, 2024 · 0 comments
Closed

Fix wasmer_api::query::fetch_webc_package #4598

theduke opened this issue Apr 24, 2024 · 0 comments
Assignees
@xdoardo
Labels
priority-high High priority issue

Comments

@theduke
Copy link
Contributor

theduke commented Apr 24, 2024

The current implemenetation has an issue:

Url::to_string() ends with a trailing slash, so the resulting would have double slashes.
We could just clone the URL and use Url::set_path().

But also, note that NamedPackageIdent has a registry field.

Originally posted by @theduke in #4532 (comment)
@theduke theduke mentioned this issue Apr 24, 2024
Merged
@xdoardo xdoardo mentioned this issue Apr 24, 2024
Closed
@syrusakbary syrusakbary added the priority-high High priority issue label May 14, 2024
@linear linear bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@xdoardo xdoardo

Labels
priority-high High priority issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@syrusakbary @theduke @xdoardo