Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backend_api: fix fetch_webc_package #4599

Closed
xdoardo opened this issue Apr 24, 2024 — with Linear · 1 comment
Closed

backend_api: fix fetch_webc_package #4599

xdoardo opened this issue Apr 24, 2024 — with Linear · 1 comment
Assignees

Comments

Copy link
Contributor

xdoardo commented Apr 24, 2024

Url::to_string() ends with a trailing slash, so this would have double slashes. We could just clone the URL and use Url::set_path(). But also, note that NamedPackageIdent has a registry field. But since this isn't actually actively used anywhere, we can do all of that in a followup to not block the merge.

Originally posted by @theduke in #4532 (comment)

@xdoardo xdoardo self-assigned this Apr 24, 2024
@xdoardo
Copy link
Contributor Author

xdoardo commented Apr 24, 2024

Dupe of #4598. Closing.

@xdoardo xdoardo closed this as completed Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant