Allow publishing packages without a module #3711
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theduke
force-pushed
the
publish-without-module
branch
2 times, most recently
from
4ca3665 to
8dca69a
Compare
Also update the lockfile
Removes the check that requires a module to be specified when publishing a package. Removed because modules should not be mandatory - packages with just a file system, or with a command that uses the module of a dependency are perfectly valid.
These were introduced by an older version of targz-to-pirita depending on an older wasmer-registry
theduke
force-pushed
the
publish-without-module
branch
from
8dca69a to
b114264
Compare
|
Closes #3712 |
|
@Michael-F-Bryan the changes here seem to regress the Python tests again. |
syrusakbary
approved these changes
Mar 27, 2023
|
@theduke I'm guessing the regression is because #3690 fixes that by removing the |
|
The package validation changes were included in #3716, since that also moves the validation code. The webc version upgrades / deduplication should be handled in a dedicated PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the check that requires a module to be specified when publishing
a package.
Removed because modules should not be mandatory - packages with just a
file system, or with a command that uses the module of a dependency are
perfectly valid.