Introduce a WebcVolumeFileSystem that works for any WEBC version #3690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-F-Bryan
force-pushed
the
webc-compat
branch
from
c890f77 to
9991980
Compare
syrusakbary
approved these changes
Mar 23, 2023
theduke
reviewed
Mar 23, 2023
Michael-F-Bryan
force-pushed
the
webc-compat
branch
from
a4775f6 to
a75522e
Compare
Michael-F-Bryan
force-pushed
the
webc-compat
branch
from
5f804a7 to
22523d3
Compare
Michael-F-Bryan
force-pushed
the
webc-compat
branch
from
22523d3 to
ded344f
Compare
Michael-F-Bryan
force-pushed
the
webc-compat
branch
2 times, most recently
from
cf2d467 to
c5dfa9f
Compare
These were introduced by an older version of targz-to-pirita depending on an older wasmer-registry
added 7 commits
April 13, 2023 23:44
Michael-F-Bryan
force-pushed
the
webc-compat
branch
from
c5dfa9f to
eba58df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a
virtual_fs::WebcVolumeFileSystemwhich builds on top of thewebc::compat::Containercompatibility layer instead of being tied towebc::v1.The runners have also been updated to use this compatibility layer directly instead of
wasmer_wasix::runners::WapmContainer.This is needed to fix #3712 because the latest version of
wapm-targz-to-piritagenerates WEBC v2 files. Currently, thewasmer_wasix::runners::WapmContainerhas atodo!()for loading WEBC v2 files because we have no way to implement thecontainer_fs(&self) -> Arc<dyn FileSystem + Send + Sync>method.