Move Package Build/Publish Logic to wasmer-registry #3716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theduke
force-pushed
the
move-publish-to-registry
branch
from
893c8b7 to
29d2830
Compare
syrusakbary
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Looks good to me once tests pass. I think we should get also a review from @Michael-F-Bryan prior to merging
Moves the logic for converting a wasmer.toml package file into a tar.gz and publishing it to the backend into the wasmer_registry crate.
Add a sensible message...
Modify the Wasmer package build logic to allow packages without a module. These packages are perfectly valid and useful (pure fs package, module comes from dependencies, ...)
theduke
force-pushed
the
move-publish-to-registry
branch
from
bc65b66 to
f39c150
Compare
Ignore some tests that are currently failing. Fixing them is tracked in #3717
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the code for building and publishing packages from wasmer.toml manifests
from the CLI to the wasmer-registry crate to make the logic reusable.