Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Add RISCV in test and build #3706

Merged
merged 52 commits into from
Apr 14, 2023
Merged

[CI] Add RISCV in test and build #3706

merged 52 commits into from
Apr 14, 2023

Conversation

ptitSeb
Copy link
Contributor

@ptitSeb ptitSeb commented Mar 24, 2023

Added RISCV in both test and build Actions

@ptitSeb ptitSeb requested a review from syrusakbary as a code owner March 24, 2023 12:42
ptitSeb added 25 commits March 24, 2023 13:52
@ptitSeb
[CI] Added libssl-dev to RISCV Doker image
05b2d2f
@ptitSeb
[CI] It's libssl-dev:riscv64 that is needed for RISCV Doker image
57a7513
@ptitSeb
[CI] More work to get riscv to be cross compiled
10afcb2
@ptitSeb
[CI] Added debian-port sid or riscv Docker image
daf963d
@ptitSeb
[CI] Added archive_2023 key for debian port
7b4250f
@ptitSeb
[CI] Try to used vendored openssl for riscv
9bd113a
@ptitSeb
[CI] Try to cross-build a localy OpenSSL for riscv
0222f09
@ptitSeb
Merge branch 'master' into ci_riscv64
835c081
@ptitSeb
[CI] gcc-riscv64-linux-gnu is not installed it seems, only g++ is
b916166
@ptitSeb
Fixed linter
5b8dedc
@ptitSeb
[CI] Fined tune OpenSSL installation on RISCV Docker image
863d33b
@ptitSeb
Fixed linter
50d0cab
@ptitSeb
[CI] Try to force RISCV64GC_UNKNOWN_LINUX_GNU_OPENSSL_DIR env. var.
bc37e32
@ptitSeb
[CI] Use the cross-rs docker image instead of creating one from scratch
af592e3
@ptitSeb
[CI] Use the katest cross-rs docker image for RISCV
3b19bcf
@ptitSeb
[CI] more attempt to get opensll for RISCV
5f31ade
@ptitSeb
[CI] nother attempt to get opensll for RISCV
1478eb4
@ptitSeb
[CI] New Docker image for riscv64 cross build
3b8fd5c
@ptitSeb
[CI] Can you please find those openssl libs now
a1b336e
@ptitSeb
[CI] Try not to use pkg-config maybe
1e8dd09
@ptitSeb
[CI] one more try
f684e0c
@ptitSeb
[CI] more openssl try
b9cb23e
@ptitSeb
[CI] again, more openssl try
cce1963
@ptitSeb
[CI] again, one more openssl try
57309ee
@ptitSeb
[CI] again and again, one more openssl try
5788909
@ptitSeb ptitSeb enabled auto-merge (squash) March 29, 2023 10:57
theduke
theduke approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't do a thorough review, but I didn't notice anything problematic. LGTM.

Docker cross-compilation is always annoying...

.github/workflows/build.yml Show resolved Hide resolved
@ptitSeb ptitSeb disabled auto-merge March 29, 2023 17:37
@ptitSeb ptitSeb enabled auto-merge (squash) March 29, 2023 17:38
@ptitSeb
Copy link
Contributor Author

ptitSeb commented Mar 30, 2023

The RISCV branch depend on using wapm-targz-to-pirita v0.2.0, but then, it need #3690 to be merge to be able to run all test without error (or else https://github.com/wasmerio/wasmer/blob/master/lib/wasi/src/runners/container.rs#L36 will be triggered)

@ptitSeb ptitSeb merged commit 01a8036 into master Apr 14, 2023
@ptitSeb ptitSeb deleted the ci_riscv64 branch April 14, 2023 08:46
theduke
theduke reviewed Apr 14, 2023
View reviewed changes
.github/workflows/web.yaml Outdated Show resolved Hide resolved
.github/workflows/web.yaml Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theduke theduke theduke approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

@Michael-F-Bryan Michael-F-Bryan Awaiting requested review from Michael-F-Bryan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ptitSeb @theduke