Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wasmer run-unstable #3650

Merged
merged 39 commits into from
Mar 21, 2023
Merged

Wasmer run-unstable #3650

merged 39 commits into from
Mar 21, 2023

Conversation

Michael-F-Bryan
Copy link
Contributor

@Michael-F-Bryan Michael-F-Bryan commented Mar 6, 2023

This implements a second version of the wasmer run command to make the flow easier to follow and use WEBC runners.

In particular, it...

  • Introduces a wasmer run-unstable sub-command which will eventually replace wasmer run and add a bunch of integration tests for it
  • Deprecates several feature flags in the CLI (cache, cache-blake3-pure, debug, wasi, emscripten, webc_runner), making sure their functionality is always included and the flags themselves are no-ops
  • Introduces a wasmer_cli::WasmerHome abstraction for interacting with the $WASMER_DIR directory and our integrating it with our caches
  • Introduces an impl<D> Filesystem for D where D: Deref<Target = impl Filesystem> so Box<dyn FileSystem> and friends implement the FileSystem trait
  • fixes a bug in wasmer_vfs::WebcFileSystem where you would OOM or have an infinite loop because reads would never increment the file's cursor
  • Propagate environment variables and mapped directories to the WASI runner
  • Wire up logging and error-handling middleware to the server started by the WCGI runner

We're calling it wasmer run-unstable instead of overwriting the wasmer run command for now until we get a chance to do more testing.

Fixes #3514.

lib/c-api/Cargo.toml Outdated Show resolved Hide resolved
@Michael-F-Bryan Michael-F-Bryan force-pushed the wasmer-run-v2 branch 4 times, most recently from 787a5eb to f44f049 Compare March 9, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Respect main_args from the wasmer.toml file when running commands
2 participants