-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wasmer run-unstable #3650
Merged
Merged
Wasmer run-unstable #3650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syrusakbary
reviewed
Mar 6, 2023
Michael-F-Bryan
force-pushed
the
wasmer-run-v2
branch
4 times, most recently
from
March 9, 2023 17:27
787a5eb
to
f44f049
Compare
syrusakbary
reviewed
Mar 9, 2023
This was referenced Mar 14, 2023
Merged
Michael-F-Bryan
force-pushed
the
wasmer-run-v2
branch
from
March 16, 2023 15:48
22c05d7
to
ec67851
Compare
Michael-F-Bryan
force-pushed
the
wasmer-run-v2
branch
from
March 17, 2023 16:40
84c24bf
to
db9753b
Compare
Michael-F-Bryan
force-pushed
the
wasmer-run-v2
branch
from
March 20, 2023 17:18
ee94b1f
to
75b891d
Compare
syrusakbary
approved these changes
Mar 20, 2023
Michael-F-Bryan
force-pushed
the
wasmer-run-v2
branch
from
March 21, 2023 09:15
f80c29b
to
ce682ce
Compare
The WasiRunner's filesystem now only has access to volumes from its container. The WcgiRunner's filesystem now only has access to mapped directories.
Michael-F-Bryan
force-pushed
the
wasmer-run-v2
branch
from
March 21, 2023 17:40
aff15fb
to
7b49f56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a second version of the
wasmer run
command to make the flow easier to follow and use WEBC runners.In particular, it...
wasmer run-unstable
sub-command which will eventually replacewasmer run
and add a bunch of integration tests for itcache
,cache-blake3-pure
,debug
,wasi
,emscripten
,webc_runner
), making sure their functionality is always included and the flags themselves are no-opswasmer_cli::WasmerHome
abstraction for interacting with the$WASMER_DIR
directory and our integrating it with our cachesimpl<D> Filesystem for D where D: Deref<Target = impl Filesystem>
soBox<dyn FileSystem>
and friends implement theFileSystem
traitwasmer_vfs::WebcFileSystem
where you would OOM or have an infinite loop because reads would never increment the file's cursorWe're calling it
wasmer run-unstable
instead of overwriting thewasmer run
command for now until we get a chance to do more testing.Fixes #3514.