Overlay FileSystem #3677
Merged
Overlay FileSystem #3677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-F-Bryan
force-pushed
the
overlay-fs
branch
2 times, most recently
from
d5c164c to
154a795
Compare
Michael-F-Bryan
force-pushed
the
overlay-fs
branch
2 times, most recently
from
7eadc29 to
18ff9ff
Compare
theduke
reviewed
Mar 15, 2023
syrusakbary
approved these changes
Mar 15, 2023
There was a problem hiding this comment.
Once the comments are addressed (except of the one suggesting a different design for OverlayFS) and the tests pass, I think we should be good to go.
Also, side comment: I think we should make WebC read only for now (basically, panic/fail on any write operation on it, and we will remove the memory filesystem on it ->
Line 24 in 444d596
If things fully work then I think we should be good to go! (note: we can do that as part of other PR if that's easier)
Michael-F-Bryan
force-pushed
the
overlay-fs
branch
from
18ff9ff to
04f3231
Compare
added 12 commits
March 16, 2023 18:08
Michael-F-Bryan
force-pushed
the
overlay-fs
branch
from
04f3231 to
6fb20e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
wasmer_vfs::overlay_fs::OverlayFileSystemwhich allows you to "overlay" multiplewasmer_vfs::FileSystemimplementations.As opposed to the
wasmer_vfs::union_fs::UnionFileSystem, which allows you to mount disjointed filesystems, theOverlayFileSystemhas a single primary filesystem and zero or more secondary filesystems, where a items from a filesystem with higher precedence will shadow items from a lower precedence filesystem.We want this as part of #3650.