Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect main_args from the wasmer.toml file when running commands #3514

Closed
fschutt opened this issue Jan 20, 2023 · 1 comment · Fixed by #3650
Closed

Respect main_args from the wasmer.toml file when running commands #3514

fschutt opened this issue Jan 20, 2023 · 1 comment · Fixed by #3650
Assignees
@Michael-F-Bryan
Labels
🎉 enhancement New feature!
Milestone
v3.2

Comments

@fschutt
Copy link
Contributor

fschutt commented Jan 20, 2023

Currently the wasmer.toml file has a main_args field for setting default arguments for the runner, however those main_args are not being respected when actually running the .wasm file (they're not passed in).

Current:

wasmer run ciuser/[email protected] customlambda.py 55

Goal:

wasmer run ciuser/[email protected] 55

The necessary changes for this are already implemented in a3d3550#diff-bc54a1b8f8ed51b1b4d84d6e94de7a3cb3a059311cac846e470dc28f0a136218R141-R146 we just need to port them to master.
@fschutt fschutt added the 🎉 enhancement New feature! label Jan 20, 2023
@syrusakbary
Copy link
Member

We need to solve this by adding custom runner configuration into wasmer.toml

@syrusakbary syrusakbary added this to the v3.2 milestone Jan 24, 2023
@Michael-F-Bryan Michael-F-Bryan mentioned this issue Mar 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Michael-F-Bryan Michael-F-Bryan

Labels
🎉 enhancement New feature!
Projects
None yet
Milestone
v3.2
Development

Successfully merging a pull request may close this issue.

Wasmer run-unstable wasmerio/wasmer
3 participants
@syrusakbary @fschutt @Michael-F-Bryan