Fix make install-capi-lib #3448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think #3380 is a better solution, without resorting to regex. |
|
I agree but it needs jq installed which is an unexpected dependency that I didn't want to introduce. I thought fixing the current solution would make it easier for upstream to accept the contribution until something better would come along. However, I'm happy to view my PR as deprecated compared to yours. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Can we merge this or the solution by @NickCao? Currently it's still broken. |
|
Merging this once all tests pass @svenstaro |
syrusakbary
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3445. The sed command was more complicated than it needed to be and it looked for the wrong character. I'm not sure why it broke, maybe cargo changed the output slightly?
Review