Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared library doesn't have correct path #3445

Closed
svenstaro opened this issue Dec 28, 2022 · 2 comments · Fixed by #3448
Closed

Shared library doesn't have correct path #3445

svenstaro opened this issue Dec 28, 2022 · 2 comments · Fixed by #3448
Labels
build-system The Wasmer repo's build and CI system priority-medium Medium priority issue

Comments

@svenstaro
Copy link
Contributor

When compiling wasmer like this:

make WASMER_INSTALL_PREFIX=/usr ENABLE_LLVM=1

and then installing it like this:

DESTDIR=/tmp make install

I'll get a file tree such as:

/tmp/wasmer
├── bin
│   └── wasmer
├── include
│   ├── wasmer.h
│   ├── wasmer-README.md
│   ├── wasmer_wasm.h
│   └── wasm.h
├── lib
│   ├── libwasmer.so -> libwasmer.so.file:///home/svenstaro/src/wasmer/lib/c-api#[email protected]
│   └── libwasmer.so.file:
│       └── home
│           └── svenstaro
│               └── src
│                   └── wasmer
│                       └── lib
│                           ├── c-api#wasmer-c-api@3 -> libwasmer.so.file:///home/svenstaro/src/wasmer/lib/c-api#[email protected]
│                           ├── c-api#[email protected] -> libwasmer.so.file:///home/svenstaro/src/wasmer/lib/c-api#[email protected]
│                           └── c-api#[email protected]

The shared library now has an unexpected path and its symlink doesn't even work as it's not aware of the DESTDIR.

@Michael-F-Bryan Michael-F-Bryan added build-system The Wasmer repo's build and CI system priority-medium Medium priority issue labels Jan 3, 2023
Copy link

stale bot commented Jan 3, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale Inactive issues or PR label Jan 3, 2024
@svenstaro
Copy link
Contributor Author

I believe this is still valid.

@stale stale bot removed the 🏚 stale Inactive issues or PR label Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-system The Wasmer repo's build and CI system priority-medium Medium priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants