Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cargo read-manifest instead of pkgid to get package version #3380

Closed
wants to merge 1 commit into from

Conversation

NickCao
Copy link

@NickCao NickCao commented Nov 26, 2022

cargo pkgid does not have a stable output format
see https://doc.rust-lang.org/cargo/commands/cargo-pkgid.html#description

Description

Review

  • Add a short description of the change to the CHANGELOG.md file

@NickCao
Copy link
Author

NickCao commented Nov 26, 2022

For issue in the wild, see Package Contents of https://archlinux.org/packages/community/x86_64/wasmer/

@NickCao
Copy link
Author

NickCao commented Dec 26, 2022

For issue in the wild, see Package Contents of https://archlinux.org/packages/community/x86_64/wasmer/

They are now working around the issue by simply deleting the files: https://github.com/archlinux/svntogit-community/blob/e05a5acf008ceca27f4b34f4ca698e4a066e3497/trunk/PKGBUILD#L33

@NickCao NickCao mentioned this pull request Dec 30, 2022
1 task
Copy link

stale bot commented Dec 27, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the 🏚 stale Inactive issues or PR label Dec 27, 2023
@syrusakbary
Copy link
Member

So far, this haven't caused any issue and introducing another dependency like jq can cause other systems to not work. Closing the PR but thanks for bringing this to our attention

@syrusakbary syrusakbary closed this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏚 stale Inactive issues or PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants