Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wasmer --version logic, integrate wapm-cli #3215

Merged
merged 94 commits into from
Oct 25, 2022
Merged

Update wasmer --version logic, integrate wapm-cli #3215

merged 94 commits into from
Oct 25, 2022

Conversation

fschutt
Copy link
Contributor

@fschutt fschutt commented Oct 4, 2022

  • Update clap
  • Integrate wapm-cli logic
  • Polish CLI handling and UX

Fixes #3208.
Fixes #3189.

@fschutt fschutt requested a review from syrusakbary as a code owner October 4, 2022 08:42
@fschutt fschutt marked this pull request as draft October 4, 2022 14:10
@syrusakbary syrusakbary added this to the v3.0 milestone Oct 5, 2022
fschutt and others added 4 commits October 19, 2022 17:49
The stdout might print something else other than just "hello",
so we need to check for the ending, not the stdout to be equal
lib/cli/src/cli.rs Outdated Show resolved Hide resolved
lib/cli/src/cli.rs Outdated Show resolved Hide resolved
lib/cli/src/cli.rs Outdated Show resolved Hide resolved
lib/cli/src/cli.rs Outdated Show resolved Hide resolved
lib/cli/src/cli.rs Outdated Show resolved Hide resolved
lib/cli/src/cli.rs Outdated Show resolved Hide resolved
lib/cli/src/cli.rs Outdated Show resolved Hide resolved
lib/cli/src/cli.rs Outdated Show resolved Hide resolved
@Michael-F-Bryan
Copy link
Contributor

bors r+

bors bot added a commit that referenced this pull request Oct 25, 2022
3215: Update wasmer --version logic, integrate wapm-cli r=Michael-F-Bryan a=fschutt

- [x] Update clap
- [x] Integrate wapm-cli logic
- [x] Polish CLI handling and UX

Fixes #3208.
Fixes #3189.

Co-authored-by: Felix Schütt <[email protected]>
Co-authored-by: Felix Schütt <[email protected]>
@bors
Copy link
Contributor

bors bot commented Oct 25, 2022

Canceled.

@Michael-F-Bryan
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 25, 2022

Build succeeded:

@bors bors bot merged commit e831932 into master Oct 25, 2022
@bors bors bot deleted the wasmer-vv branch October 25, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unify wasmer-cli and wapm-cli into one tool Include Build ID in wasmer --version
3 participants