Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include Build ID in wasmer --version #3189

Closed
fschutt opened this issue Sep 16, 2022 · 3 comments · Fixed by #3215
Closed

Include Build ID in wasmer --version #3189

fschutt opened this issue Sep 16, 2022 · 3 comments · Fixed by #3215
Assignees
Labels
🎉 enhancement New feature! priority-medium Medium priority issue

Comments

@fschutt
Copy link
Contributor

fschutt commented Sep 16, 2022

It's better to print both the version and the git ref + date when the binary was built when printing wasmer --version

@fschutt fschutt added the 🎉 enhancement New feature! label Sep 16, 2022
@syrusakbary
Copy link
Member

Yeah, this might break the wasmer --version behavior though (to upgrade wasmer). So we'll need to double check!

@syrusakbary
Copy link
Member

Things that might break: The wasmer-install process. If that works properly then we should be fine

@syrusakbary
Copy link
Member

We can have a similar thing as rustc:

➜  rustc --version
rustc 1.59.0 (9d1b2106e 2022-02-23)
➜  rustc --version --verbose
rustc 1.59.0 (9d1b2106e 2022-02-23)
binary: rustc
commit-hash: 9d1b2106e23b1abd32fce1f17267604a5102f57a
commit-date: 2022-02-23
host: aarch64-apple-darwin
release: 1.59.0
LLVM version: 13.0.0

@syrusakbary syrusakbary added the priority-medium Medium priority issue label Sep 29, 2022
@fschutt fschutt self-assigned this Sep 29, 2022
bors bot added a commit that referenced this issue Oct 25, 2022
3215: Update wasmer --version logic, integrate wapm-cli r=Michael-F-Bryan a=fschutt

- [x] Update clap
- [x] Integrate wapm-cli logic
- [x] Polish CLI handling and UX

Fixes #3208.
Fixes #3189.

Co-authored-by: Felix Schütt <[email protected]>
Co-authored-by: Felix Schütt <[email protected]>
@bors bors bot closed this as completed in e831932 Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎉 enhancement New feature! priority-medium Medium priority issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants