Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use "wasmer --version --verbose" in the issue template #3424

Merged
merged 2 commits into from
Apr 12, 2023

Conversation

Michael-F-Bryan
Copy link
Contributor

@Michael-F-Bryan Michael-F-Bryan commented Dec 13, 2022

Description

Now that the wasmer CLI can show more verbose version information (#3215), we should ask people to use it when creating tickets.

Before:

$ echo "`wasmer -V` | `rustc -V` | `uname -m`"
wasmer 3.0.2 | rustc 1.63.0 (4b91a6ea7 2022-08-08) | x86_64

After:

$ wasmer -vV; rustc -vV
wasmer 3.0.2 (5287c 2022-11-27)
binary: wasmer-cli
commit-hash: 5287c4f1253f66f428066d35eef0825fe827cff3
commit-date: 2022-11-27
host: x86_64-unknown-linux-gnu
compiler: singlepass,cranelift,llvm
rustc 1.63.0 (4b91a6ea7 2022-08-08)
binary: rustc
commit-hash: 4b91a6ea7258a947e59c6522cd5898e7c0a6a88f
commit-date: 2022-08-08
host: x86_64-unknown-linux-gnu
release: 1.63.0
LLVM version: 14.0.5

Fixes #3412.

@ptitSeb
Copy link
Contributor

ptitSeb commented Dec 13, 2022

so no more uname?
a uname -a would be interesting.
(Also, side ote, this doesn't work for Windows OS., but it has never worked...)

@Michael-F-Bryan
Copy link
Contributor Author

@ptitSeb, I removed the uname -m because it just prints x86_64, which is already covered in the host: x86_64-unknown-linux-gnu printed by rustc and wasmer.

That's a good point about platform compatibility, though. Powershell supports &&, so wasmer -Vv && rustc -Vv will work, but cmd.exe will error out with a syntax error.

@ptitSeb
Copy link
Contributor

ptitSeb commented Dec 13, 2022

I tried on Windows.
On Powershell:

PS L:\git\wasmvm> wasmer -vV && rustc -vV
Au caractère Ligne:1 : 12
+ wasmer -vV && rustc -vV
+            ~~
Le jeton « && » n’est pas un séparateur d’instruction valide.
    + CategoryInfo          : ParserError: (:) [], ParentContainsErrorRecordException
    + FullyQualifiedErrorId : InvalidEndOfLine

PS L:\git\wasmvm> wasmer -vV ; rustc -vV
wasmer 3.0.0-rc.2 (33da4 2022-11-04)
binary: wasmer-cli
commit-hash: 33da46f94ba6cc18f817428fc751ef25772cf5a5
commit-date: 2022-11-04
host: x86_64-pc-windows-msvc
compiler: singlepass,cranelift,llvm
rustc 1.64.0-nightly (27eb6d701 2022-07-04)
binary: rustc
commit-hash: 27eb6d7018e397cf98d51c205e3576951d766323
commit-date: 2022-07-04
host: x86_64-pc-windows-msvc
release: 1.64.0-nightly
LLVM version: 14.0.6

On CMD.exe

L:\git\wasmvm>wasmer -vV; rustc -vV
error: Found argument '-v' which wasn't expected, or isn't valid in this context

        If you tried to supply `-v` as a value rather than a flag, use `-- -v`

USAGE:
    wasmer [OPTIONS] <FILE> [ARGS]...

For more information try --help

L:\git\wasmvm>wasmer -vV ; rustc -vV
wasmer 3.0.0-rc.2 (33da4 2022-11-04)
binary: wasmer-cli
commit-hash: 33da46f94ba6cc18f817428fc751ef25772cf5a5
commit-date: 2022-11-04
host: x86_64-pc-windows-msvc
compiler: singlepass,cranelift,llvm

L:\git\wasmvm>wasmer -vV : rustc -vV
wasmer 3.0.0-rc.2 (33da4 2022-11-04)
binary: wasmer-cli
commit-hash: 33da46f94ba6cc18f817428fc751ef25772cf5a5
commit-date: 2022-11-04
host: x86_64-pc-windows-msvc
compiler: singlepass,cranelift,llvm

L:\git\wasmvm>wasmer -vV && rustc -vV
wasmer 3.0.0-rc.2 (33da4 2022-11-04)
binary: wasmer-cli
commit-hash: 33da46f94ba6cc18f817428fc751ef25772cf5a5
commit-date: 2022-11-04
host: x86_64-pc-windows-msvc
compiler: singlepass,cranelift,llvm
rustc 1.64.0-nightly (27eb6d701 2022-07-04)
binary: rustc
commit-hash: 27eb6d7018e397cf98d51c205e3576951d766323
commit-date: 2022-07-04
host: x86_64-pc-windows-msvc
release: 1.64.0-nightly
LLVM version: 14.0.6

I don't think there is an universal solution here :(

@ptitSeb ptitSeb self-requested a review December 13, 2022 11:06
@Michael-F-Bryan
Copy link
Contributor Author

@ptitSeb, this error message is very surprising:

$ wasmer -vV; rustc -vV
error: Found argument '-v' which wasn't expected, or isn't valid in this context

        If you tried to supply `-v` as a value rather than a flag, use `-- -v`

USAGE:
    wasmer [OPTIONS] <FILE> [ARGS]...

For more information try --help

It's almost like Windows does something different with command-line arguments, so wasmer doesn't recognise the -v flag as valid 🤔

@ptitSeb
Copy link
Contributor

ptitSeb commented Dec 13, 2022

It's because of the lack of space between V and ;... Windows CMD parser is .. crude...

@Michael-F-Bryan Michael-F-Bryan merged commit c608eb8 into master Apr 12, 2023
@Michael-F-Bryan Michael-F-Bryan deleted the issue-template branch April 12, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend Issue Template - Host OS and Architecture
3 participants