Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SharedMemory & Atomics #3153

Merged
merged 28 commits into from
Nov 29, 2022
Merged

SharedMemory & Atomics #3153

merged 28 commits into from
Nov 29, 2022

Conversation

ptitSeb
Copy link
Contributor

@ptitSeb ptitSeb commented Aug 31, 2022 •
edited
Loading

Description

Enabled SharedMemory and the Atomics extension proposal

For #3304

@ptitSeb ptitSeb requested a review from syrusakbary as a code owner August 31, 2022 08:10
@ptitSeb ptitSeb added this to the v3.x milestone Aug 31, 2022
@ptitSeb ptitSeb mentioned this pull request Sep 6, 2022
Closed
john-sharratt and others added 18 commits November 22, 2022 14:11
@john-sharratt @ptitSeb
Implemented shared memory for Wasmer in preparation for multithreading
a5f641b 
Fixed linter

Fixed clippy

Cleaned up some merge leftover
@ptitSeb
Added spec threads tests, but disabling all for now
34cba1c 
Fixed linter
@ptitSeb
Enabled threads and already working tests
013d634
@ptitSeb
Added some missing emitter on x86_64 singlepass (for #3161)
2b7bf2f 
Checked align_check for x86_64 singlepass compiler (for #3161)"

Added proper handling of Unaligned Atomics in Singlepass Compiler (for #3161)

More fixes to x86_64 singlepass compiler (for #3161)
@ptitSeb
Added helper functions for WaitNotify opcodes (for #3155)
9bbcc8a
@ptitSeb
Added Wait/Notify opcode handling to Sinbglepass, and enable x86_64 t…
bfc8d94 
…hreads::atomic test (for #3158)
@ptitSeb
Map cranelift HeapMisaligned to wasmer UnalignedAtomic trap code (for #…
9472576 
…3162)
@ptitSeb
Fixed Notify helper funciton and opcode (for #3155 and #3158)
bb69903
@ptitSeb
Added Wait/Notify opcodes for cranelift compiler (for #3156)
516da67
@ptitSeb
Fixed clippy warning on using Self
04a03fc
@ptitSeb
Added Wait / Notify opcode to LLVM compiler (for #3157)
6ed8e48
@ptitSeb
Fixed linter
74721a8
@ptitSeb
Fixed Alignment check for Atomic access in LLVM compiler (for #3163)
12ce309
@ptitSeb
Added some aarch64 atomic access emitter (not finished)
8a0bd4b 
Removed public Imports::import_shared_memory and try to auto-initialize shared memory directly

Fixed clippy

Added Atomic Add/Sub/And/Or/Xor operator to Singlepass/AArch64 backend

Added atomic_xchg support for Singlepass/AArch64 backend

Finished all atomic access operator for Singlepass/Aarch64 backend
@ptitSeb
Fixed issue #3167 and added the relevant test
e4523f7
@syrusakbary @ptitSeb
Added exists function to imports
519f29b
@ptitSeb
Moved import_shared_memory to wasi specific, and use this function on…
b86f129 
… the run/wasi cli command directly

Fixed linter

Fixed js build

Fixed linter
@ptitSeb
Enable threads/imports test, but disabling multiple table individual …
3144ef2 
…tests as it's not yet supported
@ptitSeb ptitSeb requested a review from theduke November 24, 2022 15:04
theduke
theduke requested changes Nov 24, 2022
View reviewed changes
lib/vm/src/instance/mod.rs Outdated Show resolved Hide resolved
lib/vm/src/instance/mod.rs Outdated Show resolved Hide resolved
lib/vm/src/instance/mod.rs Outdated Show resolved Hide resolved
lib/vm/src/instance/mod.rs Outdated Show resolved Hide resolved
lib/vm/src/instance/mod.rs Outdated Show resolved Hide resolved
lib/vm/src/instance/mod.rs Show resolved Hide resolved
lib/vm/src/instance/mod.rs Show resolved Hide resolved
tests/wast/wasmer/atomic_load.wast Show resolved Hide resolved
ptitSeb and others added 2 commits November 24, 2022 18:11
@ptitSeb @theduke
Update lib/vm/src/instance/mod.rs
fce0ac9 
Co-authored-by: Christoph Herzog <[email protected]>
@ptitSeb @theduke
Update lib/vm/src/instance/mod.rs
dba6a6a 
Co-authored-by: Christoph Herzog <[email protected]>
@ptitSeb ptitSeb requested a review from theduke November 25, 2022 12:07
@theduke
Copy link
Contributor

theduke commented Nov 25, 2022

I assume you validated the alignment checking for notify?

ps: I noticed that the official .wast suite doesn't seem to test notify alignment, so we might want to send them an issue to add that. (unless I missed it).

theduke
theduke approved these changes Nov 25, 2022
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the NotifyMap!

@ptitSeb
Copy link
Contributor Author

ptitSeb commented Nov 29, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 29, 2022

Build succeeded:

  • Code lint

@bors bors bot merged commit 256755b into master Nov 29, 2022
@bors bors bot deleted the feat_sharedmemory branch November 29, 2022 14:59
@ptitSeb ptitSeb modified the milestones: v3.x, v3.1 Nov 30, 2022
@fschutt fschutt mentioned this pull request Dec 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary left review comments

@theduke theduke theduke approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.1
Development

Successfully merging this pull request may close these issues.
4 participants
@ptitSeb @theduke @syrusakbary @john-sharratt