-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Weird behavior for atomic load #3167
Comments
Sorry forgot to add this. It was tested using |
What compiler are you using? Cranelift (the default one) or Singlepass? |
Cranelift |
Ok, thanks. I'll have a look at it. It seems there is the same "warp around" issue as with wasmtime. |
ptitSeb
added a commit
that referenced
this issue
Oct 10, 2022
ptitSeb
added a commit
that referenced
this issue
Nov 22, 2022
bors bot
added a commit
that referenced
this issue
Nov 29, 2022
3153: SharedMemory & Atomics r=ptitSeb a=ptitSeb # Description Enabled SharedMemory and the Atomics extension proposal - [x] Enable Atomic extension by default - [x] Fix "imports" tests #3154 - [x] Add function for memory.atomic.wait32, memory.atomic.wait64 and memory.atomic.notify opcodes #3155 - [x] Add support for the new wait/notify opcodes in Cranelift compiler #3156 - [x] Add support for the new wait/notify opcodes in LLVM compiler #3157 - [x] Add support for atomic access opcodes in AArch64/Singlepass compiler #3159 - [x] Add support for the new wait/notify opcodes in Singlepass compiler #3158 - [x] Fix Atomic issues on x86_64 Singlepass compiler not related to Wait/Notify opcodes #3161 - [x] Fix Atomic issues on Cranelift compiler not related to Wait/Notify opcodes #3162 - [x] Fix Atomic issues on LLVM compiler not related to Wait/Notify opcodes #3163 - [x] Fix the ticket #3167 on Cranelift For #3304 Co-authored-by: John Sharratt's Shared Account <[email protected]> Co-authored-by: ptitSeb <[email protected]> Co-authored-by: Syrus Akbary <[email protected]>
Merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
i32.atomic.load
won't give a runtime error for out-of-bounds access.Steps to reproduce
Run with
wasmer --enable-all atomic.wat
Expected behavior
We think this should be a runtime OOB error but wasmer will return normally.
If the
0xffff_fff0
is changed to0xfff0
, wasmer will then give OOB error. Or if thei32.atomic.load
is changed toi32.load
, wasmer will also give the error.Please excuse us if this behavior is intended. Also, the test is collected from bytecodealliance/wasmtime#3132 in case the discussion there might be useful.
Thanks.
The text was updated successfully, but these errors were encountered: