Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Wait & Notify OpCodes to Singlepass Compiler #3158

Closed
ptitSeb opened this issue Aug 31, 2022 · 1 comment
Closed

Add Wait & Notify OpCodes to Singlepass Compiler #3158

ptitSeb opened this issue Aug 31, 2022 · 1 comment
Labels
🎉 enhancement New feature! priority-medium Medium priority issue
Milestone
v3.1

Comments

@ptitSeb
Copy link
Contributor

ptitSeb commented Aug 31, 2022

Motivation

Once the helper function are created with #3155 , adding the opcode should be straitforward.

Proposed solution

Using the helper functions, add the 3 missing opcodes and enable the threads::atomic tests for Singlepass Compiler.

If needed, specs are there: https://github.com/WebAssembly/threads/blob/main/proposals/threads/Overview.md
@ptitSeb ptitSeb added the 🎉 enhancement New feature! label Aug 31, 2022
@ptitSeb ptitSeb mentioned this issue Aug 31, 2022
Merged
11 tasks
@ptitSeb ptitSeb added this to the v3.x milestone Aug 31, 2022
@ptitSeb ptitSeb mentioned this issue Aug 31, 2022
Closed
ptitSeb added a commit that referenced this issue Sep 6, 2022
@ptitSeb
Added Wait/Notify opcode handling to Sinbglepass, and enable x86_64 t…
8ceee4c 
…hreads::atomic test (for #3158)
ptitSeb added a commit that referenced this issue Sep 6, 2022
@ptitSeb
Fixed Notify helper funciton and opcode (for #3155 and #3158)
21caf9d
@syrusakbary syrusakbary added the priority-medium Medium priority issue label Sep 6, 2022
@ptitSeb ptitSeb modified the milestones: v3.x, v3.1 Nov 16, 2022
ptitSeb added a commit that referenced this issue Nov 22, 2022
@ptitSeb
Added Wait/Notify opcode handling to Sinbglepass, and enable x86_64 t…
bfc8d94 
…hreads::atomic test (for #3158)
ptitSeb added a commit that referenced this issue Nov 22, 2022
@ptitSeb
Fixed Notify helper funciton and opcode (for #3155 and #3158)
bb69903
bors bot added a commit that referenced this issue Nov 29, 2022
@bors @john-sharratt
@ptitSeb @syrusakbary
Merge #3153
256755b 
3153: SharedMemory & Atomics r=ptitSeb a=ptitSeb

# Description
Enabled SharedMemory and the Atomics extension proposal

- [x] Enable Atomic extension by default
- [x] Fix "imports" tests #3154
- [x] Add function for memory.atomic.wait32, memory.atomic.wait64 and memory.atomic.notify opcodes #3155
- [x] Add support for the new wait/notify opcodes in Cranelift compiler #3156 
- [x] Add support for the new wait/notify opcodes in LLVM compiler #3157
- [x] Add support for atomic access opcodes in AArch64/Singlepass compiler #3159
- [x] Add support for the new wait/notify opcodes in Singlepass compiler #3158
- [x] Fix Atomic issues on x86_64 Singlepass compiler not related to Wait/Notify opcodes #3161
- [x] Fix Atomic issues on Cranelift compiler not related to Wait/Notify opcodes #3162
- [x] Fix Atomic issues on LLVM compiler not related to Wait/Notify opcodes #3163
- [x] Fix the ticket #3167 on Cranelift

For #3304 

Co-authored-by: John Sharratt's Shared Account <[email protected]>
Co-authored-by: ptitSeb <[email protected]>
Co-authored-by: Syrus Akbary <[email protected]>
@ptitSeb
Copy link
Contributor Author

ptitSeb commented Dec 6, 2022

Merged

@ptitSeb ptitSeb closed this as completed Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎉 enhancement New feature! priority-medium Medium priority issue
Projects
None yet
Milestone
v3.1
Development

No branches or pull requests
2 participants
@syrusakbary @ptitSeb