change host_state drop order for InstanceHandle #2812
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is following #2806
We still met
prev.start > max
assertion error even after we pathed #2806.#2086 seem fixed drop order problem on
Module
, but not solved it when we useInstance
.I found some other place which can cause drop order problem when we use
Instance
.After we patch this, I couldn't see more
prev.start > max
assertion.This instance handle will be stay in
wasmer/lib/vm/src/instance/mod.rs
Lines 100 to 101 in 7fbaf6f
Instance
.Review