Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change host_state drop order for InstanceHandle #2812

Merged
merged 3 commits into from
Mar 7, 2022
Merged

change host_state drop order for InstanceHandle #2812

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6be22e
change host_state drop order to drop artifact first
yun-yeo Mar 2, 2022
2f10460
move drop responsibility to the module itself
yun-yeo Mar 4, 2022
646a405
Merge branch 'master' into bugfix/instantiate-drop-order
yun-yeo Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/api/src/sys/module.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ impl Module {
let instance_handle = self.artifact.instantiate(
self.store.tunables(),
resolver,
Box::new((self.store.clone(), self.artifact.clone())),
Box::new((self.artifact.clone(), self.store.clone())),
yun-yeo marked this conversation as resolved.
Show resolved Hide resolved
)?;

// After the instance handle is created, we need to initialize
Expand Down