-
Notifications
You must be signed in to change notification settings - Fork 287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix memory leak and module drop order #690
Conversation
Codecov Report
@@ Coverage Diff @@
## main #690 +/- ##
=======================================
Coverage 45.46% 45.46%
=======================================
Files 121 121
Lines 7063 7063
=======================================
Hits 3211 3211
Misses 3605 3605
Partials 247 247 |
It contains all the fixes we needed (drop order fix); therefore vanilla cosmwasm 0.16.6 is usable without any modifications. We believe drop order fix fixed mem leak too. tho wasmer 2.2.1 changed its cache module format, and cosmwasm is forced to rebuild all cache upon request (either execute/query). ^ this can eat up resources under heavy concurrency; We wrote a script to rebuild module cache from .wasm blobs to the new format — https://github.com/kjessec/wasm-cache-rebuilder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Summary of changes
close #683
This PR is picking custom
wasmer
andcosmwasm
andwasmvm
to fix following problems:prev.start > max
assertion, which is commonly known aspoison error
Report of required housekeeping
(FOR ADMIN) Before merging