Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement aarch64 ABI for compiler-llvm. #1754

Merged
merged 8 commits into from
Oct 23, 2020
Merged

Implement aarch64 ABI for compiler-llvm. #1754

merged 8 commits into from
Oct 23, 2020

Conversation

nlewycky
Copy link
Contributor

With this PR, make llvm-test-native passes on our arm64 machine.

@nlewycky
Make abi a trait.
fa8e423
@nlewycky
Add a get_abi(TargetMachine) method instead of creating X86_64SystemV…
e4981c4 
… directly.

A new Arm64Linux ABI is added but it's an unedited copy of the X86_64SystemV one so far.

A bunch of cleanups from clippy. Use matches! more, don't pass &Box<dyn Abi>.
@nlewycky
Implement aarch64 procedure call ABI (AAPCS64).
9e2bf26 
Fix the autodetection of which Abi to pick.
@nlewycky
Merge branch 'master' into feature/llvm-abi-trait
2add1de
@nlewycky nlewycky requested a review from losfair as a code owner October 22, 2020 23:38
@syrusakbary
Copy link
Member

Can we enable the tests for this?

@nlewycky
Copy link
Contributor Author

Can we enable the tests for this?

That's my next task. Because cranelift+jit is on, if I turn on llvm too it will try to test llvm+jit which does not work at all. If I turn off jit, and turn on llvm, we'll stop testing cranelift+jit.

@syrusakbary
Copy link
Member

That's my next task. Because cranelift+jit is on, if I turn on llvm too it will try to test llvm+jit which does not work at all. If I turn off jit, and turn on llvm, we'll stop testing cranelift+jit.

You mean to be done in the same PR on a separate one?

@nlewycky
Copy link
Contributor Author

nlewycky commented Oct 23, 2020 •
edited
Loading

You mean to be done in the same PR on a separate one?

In a separate one, if all goes according to main plan.

My backup plan is that if this PR hasn't landed by the time I have the Makefile change for the testing ready, then I'll make the other PR be "add individual testing of $(compiler_engine) configurations" and then this PR would add llvm-native to the testing.

@nlewycky
Copy link
Contributor Author

My backup plan is that if this PR hasn't landed by the time I have the Makefile change for the testing ready, then I'll make the other PR be "add individual testing of $(compiler_engine) configurations" and then this PR would add llvm-native to the testing.

That other PR is now out for review, #1720 . If that lands first then I'll update this PR to add testing of llvm-native to aarch64.

@nlewycky
Copy link
Contributor Author

Testing is now enabled!

@nlewycky
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 23, 2020

Build succeeded:

@bors bors bot merged commit 7eddb46 into master Oct 23, 2020
@bors bors bot deleted the feature/llvm-abi-trait branch October 23, 2020 22:06
@Hywan
Copy link
Contributor

Hywan commented Oct 26, 2020

Impressive PR, well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

@losfair losfair Awaiting requested review from losfair

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nlewycky @syrusakbary @Hywan