Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autodetect llvm regardless of architecture. #1720

Merged
merged 5 commits into from
Oct 23, 2020
Merged

Autodetect llvm regardless of architecture. #1720

merged 5 commits into from
Oct 23, 2020

Conversation

nlewycky
Copy link
Contributor

No description provided.

@nlewycky nlewycky marked this pull request as draft October 14, 2020 17:59
@nlewycky nlewycky marked this pull request as ready for review October 14, 2020 18:18
@nlewycky nlewycky marked this pull request as draft October 14, 2020 18:19
@nlewycky
Copy link
Contributor Author

We can't land this just yet, it will cause make test to fail on arm as it runs make test-llvm-jit which doesn't work.

@nlewycky
Merge branch 'master' into feature/arm-llvm-makefile
3db80f7
@nlewycky
Merge branch 'master' into feature/arm-llvm-makefile
a09e999
@nlewycky
Autodetect which compiler-engine pairs should be tested with make test.
a2c09d2 
This also means that `make singlepass-native` will test that again showing that it doesn't work, but `make test` will never run that rule.
@nlewycky nlewycky marked this pull request as ready for review October 23, 2020 18:50
@nlewycky
Copy link
Contributor Author

This is now substantially different from when it was last reviewed, please take another look!

@nlewycky nlewycky mentioned this pull request Oct 23, 2020
Merged
@nlewycky
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Oct 23, 2020

Build succeeded:

@bors bors bot merged commit a49c4e5 into master Oct 23, 2020
@bors bors bot deleted the feature/arm-llvm-makefile branch October 23, 2020 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkMcCaskey MarkMcCaskey MarkMcCaskey approved these changes

@jubianchi jubianchi jubianchi approved these changes

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nlewycky @syrusakbary @jubianchi @MarkMcCaskey