Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement aarch64 ABI for compiler-llvm. #1754

Merged
merged 8 commits into from
Oct 23, 2020
+1,457 −799
Merged

Implement aarch64 ABI for compiler-llvm. #1754

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fa8e423
Make abi a trait.
nlewycky Oct 20, 2020
e4981c4
Add a get_abi(TargetMachine) method instead of creating X86_64SystemV…
nlewycky Oct 20, 2020
9e2bf26
Implement aarch64 procedure call ABI (AAPCS64).
nlewycky Oct 22, 2020
2add1de
Merge branch 'master' into feature/llvm-abi-trait
nlewycky Oct 22, 2020
282a16d
Remove commented-out debugging code.
nlewycky Oct 23, 2020
88843e1
Merge branch 'master' into feature/llvm-abi-trait
nlewycky Oct 23, 2020
4fc5993
Enable testing of llvm-native on aarch64.
nlewycky Oct 23, 2020
e89b1c0
Split the ABIs into separate implementations and trait files.
nlewycky Oct 23, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,9 @@ endif

ifeq ($(ARCH), aarch64)
test_compilers_engines += cranelift-jit
ifneq (, $(findstring llvm,$(compilers)))
test_compilers_engines += llvm-native
endif
endif

compilers := $(filter-out ,$(compilers))
Expand Down
4 changes: 2 additions & 2 deletions lib/compiler-llvm/src/compiler.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ impl SymbolRegistry for ShortNames {
Ok(v) => v,
Err(_) => return None,
};
match ty.chars().nth(0).unwrap() {
match ty.chars().next().unwrap() {
'f' => Some(Symbol::LocalFunction(LocalFunctionIndex::from_u32(idx))),
's' => Some(Symbol::Section(SectionIndex::from_u32(idx))),
't' => Some(Symbol::FunctionCallTrampoline(SignatureIndex::from_u32(
Expand Down Expand Up @@ -267,7 +267,7 @@ impl Compiler for LLVMCompiler {
self.config(),
memory_styles,
&table_styles,
&mut ShortNames {},
&ShortNames {},
)
},
)
Expand Down
Loading