Standard exception types for singlepass backend. #1129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
losfair
requested review from
bjfish,
Hywan,
MarkMcCaskey,
nlewycky and
syrusakbary
as code owners
|
bors try |
tryBuild succeeded
|
Hywan
approved these changes
Jan 13, 2020
lib/runtime-core/src/error.rs
Outdated
| @@ -208,6 +209,8 @@ impl std::fmt::Display for RuntimeError { | |||
| write!(f, "\"{}\"", s) | |||
| } else if let Some(s) = data.downcast_ref::<&str>() { | |||
| write!(f, "\"{}\"", s) | |||
| } else if let Some(exc_code) = data.downcast_ref::<ExceptionCode>() { | |||
| write!(f, "\"{:?}\"", exc_code) | |||
There was a problem hiding this comment.
Maybe we should write it is an exception code, so that the user has more insight than the variant name. My suggestion:
write!(f, "exception code \"{:?}\"", exc_code)There was a problem hiding this comment.
Thanks! Fixed and now the error message looks like Error: RuntimeError: Caught exception of type "Arithmetic"..
Hywan
added
🎉 enhancement
nlewycky
reviewed
Jan 15, 2020
|
@nlewycky I just updated By the way, I think it would be good to refactor |
nlewycky
approved these changes
Jan 15, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 16, 2020
1129: Standard exception types for singlepass backend. r=syrusakbary a=losfair Co-authored-by: losfair <[email protected]>
Build failed |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 20, 2020
1129: Standard exception types for singlepass backend. r=losfair a=losfair Co-authored-by: losfair <[email protected]>
|
bors r- |
Canceled |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jan 20, 2020
1129: Standard exception types for singlepass backend. r=losfair a=losfair Co-authored-by: losfair <[email protected]>
Build succeeded
|
|
Great job! I have a small question: why these traps are |
bors bot
added a commit
that referenced
this pull request
Feb 10, 2020
1192: Use `ExceptionCode` for error representation. r=losfair a=losfair Extends #1129 to all backends. Co-authored-by: losfair <[email protected]>
bors bot
added a commit
that referenced
this pull request
Feb 10, 2020
1192: Use `ExceptionCode` for error representation. r=losfair a=losfair Extends #1129 to all backends. Co-authored-by: losfair <[email protected]>
bors bot
added a commit
that referenced
this pull request
Feb 10, 2020
1192: Use `ExceptionCode` for error representation. r=losfair a=losfair Extends #1129 to all backends. Co-authored-by: losfair <[email protected]>
bors bot
added a commit
that referenced
this pull request
Feb 11, 2020
1192: Use `ExceptionCode` for error representation. r=losfair a=losfair Extends #1129 to all backends. Co-authored-by: losfair <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.