-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standard exception types for singlepass backend. #1129
Merged
Merged
Changes from 9 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
5c15ff9
`ExceptionCode` and `ExceptionTable`.
losfair f44517b
Look up exception tables in trap handler.
losfair 4b5b897
Serialize/deserialize exception codes.
losfair 8bf0c19
Push code version for non-WASI entrypoints.
losfair 0a23327
Emit exception table in singlepass.
losfair 9e2080d
Run cargo fmt.
losfair 10da5ba
Merge remote-tracking branch 'origin/master' into feature/unified-exc…
losfair 42e5e78
Merge remote-tracking branch 'origin/master' into feature/unified-exc…
losfair f4fb107
Fix type of `backend` passed to `push_code_version`.
losfair a45cbd6
Merge remote-tracking branch 'origin/master' into feature/unified-exc…
losfair 6dfd591
Improve error message on exception.
losfair 35870b3
Update spectests to test singlepass traps.
losfair 1b3e679
Merge remote-tracking branch 'origin/master' into feature/unified-exc…
losfair d3ebb5f
Merge remote-tracking branch 'origin/master' into feature/unified-exc…
losfair 16dee04
Add aarch64-specific failure excludes.
losfair 74eb113
Merge remote-tracking branch 'origin/master' into feature/unified-exc…
losfair dc21636
Fix backend string type.
losfair 5266116
Merge remote-tracking branch 'origin/master' into feature/unified-exc…
losfair 1b5d9f2
Update changelog.
losfair File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should write it is an exception code, so that the user has more insight than the variant name. My suggestion:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Fixed and now the error message looks like
Error: RuntimeError: Caught exception of type "Arithmetic".
.