Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix FunctionCallError(WasmTrap("unknown")) #2009

Closed
MaksymZavershynskyi opened this issue Jan 23, 2020 · 2 comments
Closed

Fix FunctionCallError(WasmTrap("unknown")) #2009

MaksymZavershynskyi opened this issue Jan 23, 2020 · 2 comments
Assignees
@lexfrl
Labels
A-RPC Area: rpc A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) P-critical Priority: critical

Comments

@MaksymZavershynskyi
Copy link
Contributor

Currently when contract fails we return a non-descriptive error message FunctionCallError(WasmTrap("unknown")) we were not able to return a more descriptive message because it was not supported by Wasmer Singlepass: wasmerio/wasmer#903

However, now it is fixed: wasmerio/wasmer#1129

We should update to the new version of Wasmer+Singlepass and make sure this error message is now descriptive in our RPC by writing a test.
@MaksymZavershynskyi MaksymZavershynskyi added P-critical Priority: critical A-RPC Area: rpc A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) labels Jan 23, 2020
@weekly-digest weekly-digest bot mentioned this issue Jan 24, 2020
Closed
@MaksymZavershynskyi
Copy link
Contributor Author

Moving it to in progress since I know that @fckt is currently working on it.

@lexfrl
Copy link
Contributor

lexfrl commented Feb 5, 2020 •
edited
Loading

With near/near-sdk-rs#73 @evgenykuzyakov implemented Rust will call a panic extern on panic. Now we expect panics to return the FunctionCallError::HostError::GuestPanic{ panic_msg: String }.

@lexfrl lexfrl closed this as completed Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lexfrl lexfrl

Labels
A-RPC Area: rpc A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) P-critical Priority: critical
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lexfrl @MaksymZavershynskyi