Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the debug_output setting from snaspshot tests #3942

Closed
theduke opened this issue Jun 1, 2023 · 0 comments · Fixed by #3950
Closed

Remove the debug_output setting from snaspshot tests #3942

theduke opened this issue Jun 1, 2023 · 0 comments · Fixed by #3950
Assignees
@theduke
Labels
priority-medium Medium priority issue
Milestone
v4.0

Comments

@theduke
Copy link
Contributor

theduke commented Jun 1, 2023

This setting makes litlte sense, since debug output is inherently unreliable and depends on lots of conditions.
@theduke theduke self-assigned this Jun 1, 2023
This was referenced Jun 1, 2023
Merged
Merged
theduke added a commit that referenced this issue Jun 5, 2023
@theduke
tests: Remove debug_output option from snapshot tests.
35485e5 
This option didn't really make any sense to begin with, tracing log
output is highly variable and can change at any time depending on
internals.

It should not be included in test snapshot output.

Closes #3942
Michael-F-Bryan pushed a commit that referenced this issue Jun 6, 2023
@theduke
tests: Remove debug_output option from snapshot tests.
83846b8 
This option didn't really make any sense to begin with, tracing log
output is highly variable and can change at any time depending on
internals.

It should not be included in test snapshot output.

Closes #3942
@ptitSeb ptitSeb added this to the v4.0 milestone Jun 6, 2023
@ptitSeb ptitSeb added the priority-medium Medium priority issue label Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theduke theduke

Labels
priority-medium Medium priority issue
Projects
None yet
Milestone
v4.0
Development

Successfully merging a pull request may close this issue.

tests: Remove debug_output option from snapshot tests. wasmerio/wasmer
2 participants
@theduke @ptitSeb