Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename "wasmer run-unstable" to "wasmer run" #3924

Merged
merged 30 commits into from
Jun 1, 2023
Merged

Rename "wasmer run-unstable" to "wasmer run" #3924

merged 30 commits into from
Jun 1, 2023

Conversation

Michael-F-Bryan
Copy link
Contributor

Now that we've been using the wasmer run-unstable flow for a while, it's time to promote it to wasmer run.

Closes #3801.

@theduke theduke force-pushed the wasmer-run-rename branch from a4583df to eec73b7 Compare May 31, 2023 15:49
@Michael-F-Bryan Michael-F-Bryan marked this pull request as ready for review May 31, 2023 16:22
@Michael-F-Bryan Michael-F-Bryan enabled auto-merge May 31, 2023 19:01
ptitSeb
ptitSeb reviewed Jun 1, 2023
View reviewed changes
Makefile Outdated Show resolved Hide resolved
Michael-F-Bryan and others added 24 commits June 1, 2023 19:56
Rename "wasmer run-unstable" to "wasmer run"
1e54331
Added "run-unstable" as an alias of "wasmer run" for backwards compat…
7c4834f 
…ibility
Tweaked the snapshot logging flag
2b4e3be
The stderr in snapshot tests shouldn't contain log messages
464bcd4
Make "wasmer run-unstable" exit with a WASI exit code
d9df1c1
Allow runners to set WASI capabilities (fixes the async threads snaps…
2c161b6 
…hot test)
Make the stack_size argument always present
18620ac
Update an assertion
eed8ac5
@theduke
tests: Fix test assertion for new "run" output
23f2739
@theduke
build: Add make commands for debug integration cli tests
081c840 
"test-integration-cli-debug" will run the integration tests with the
debug binary instead.
@theduke
Improve --mapdir mounting
55f8e22 
This improves --mapdir mounting in multiple ways:

* mounted paths are always canonicalized to absolute paths
  (both guest and host path)

* mapping a directory into the root of the file system ( '/' ) now works
  by individually mounting all direct descendants of the mounted
  directory
@theduke
Don't preopen / when mapping directories
1d06a2f
@theduke
chore: Fix lint
63faa97
@theduke
Actually mount when mapping into /
3ea6b86
We should be canonicalizing with OS APIs directly because our vfs lay…
48ecff0 
…er doesn't handle Windows paths
Updated the test for filtering out log lines in snapshot test output
1e32e9c
Switch the "wasmer run" integration tests over to the assert-cli crate
fe95c22
Clippy lints
a6945d1
Make sure canonicalize_without_inode() can handle UNC paths
d90049f
Add more context to wasi runner errors
2c1d2c9
It doesn't make sense to --mapdir "." when running Python
27b440c
Deleted some dead code
47e7980
Fix the UNC logic in canoncialize_without_inode()
26cd672
Remove a redundant #[ignore] on Windows
7711432
@Michael-F-Bryan Michael-F-Bryan requested a review from theduke June 1, 2023 14:19
theduke
theduke approved these changes Jun 1, 2023
View reviewed changes
Copy link
Contributor

@theduke theduke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, with two relatively small change requests.

lib/wasi/src/state/builder.rs Show resolved Hide resolved
tests/integration/cli/tests/snapshot.rs Show resolved Hide resolved
@Michael-F-Bryan Michael-F-Bryan merged commit bc449a5 into master Jun 1, 2023
@Michael-F-Bryan Michael-F-Bryan deleted the wasmer-run-rename branch June 1, 2023 16:57
@Michael-F-Bryan Michael-F-Bryan mentioned this pull request Jun 2, 2023
Merged
@Michael-F-Bryan Michael-F-Bryan mentioned this pull request Jun 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptitSeb ptitSeb ptitSeb left review comments

@theduke theduke theduke approved these changes

@syrusakbary syrusakbary Awaiting requested review from syrusakbary

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rename "wasmer run-unstable" to "wasmer run"
3 participants
@Michael-F-Bryan @theduke @ptitSeb