tests: Remove debug_output option from snapshot tests. #3950
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-F-Bryan
approved these changes
Jun 6, 2023
Michael-F-Bryan
force-pushed
the
issue-3942-remove-snapshot-debug-output
branch
from
35485e5 to
83846b8
Compare
This option didn't really make any sense to begin with, tracing log output is highly variable and can change at any time depending on internals. It should not be included in test snapshot output. Closes #3942
theduke
force-pushed
the
issue-3942-remove-snapshot-debug-output
branch
from
83846b8 to
829b948
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option didn't really make any sense to begin with, tracing log
output is highly variable and can change at any time depending on
internals.
It should not be included in test snapshot output.
Closes #3942