Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Tanks of Freedom to Spanish #96

Merged
merged 2 commits into from
Jan 7, 2019
Merged

Translate Tanks of Freedom to Spanish #96

merged 2 commits into from
Jan 7, 2019

Conversation

xexio
Copy link
Contributor

@xexio xexio commented Jan 1, 2019

Spanish translation of Tanks of Freedom

w84death
w84death reviewed Jan 3, 2019
View reviewed changes
README.md Outdated
@@ -1,4 +1,4 @@
# Tanks of Freedom
# Tanks of Freedom - Added Spanish translation
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the title of the readme file. Do not change it's title like that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the change

w84death
w84death reviewed Jan 3, 2019
View reviewed changes
README.md Outdated
@@ -91,7 +91,7 @@ For online funcionalities a ToF server is required. Sources can be found in a se
### gfx
- w84death http://krzysztofjankowski.com licensed under MIT
- Free font Courier Prime http://www.quoteunquoteapps.com/courierprime/ licensed under OFL
- NotoSans font licensed under Apache License 2.0
- NotoSans fonr licensed under Apache License 2.0
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why? or mistake?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reverted the change

@w84death w84death merged commit e3080ca into w84death:master Jan 7, 2019
@czlowiekimadlo
Copy link
Collaborator

I have integrated all new translation PRs, now you should be able to pull new commits and run the game from editor with ES language available in options. Merging script complained, that some labels might be too long:
LABEL_AUTO_FOLLOW,
LABEL_WORKSHOP_SELECTED_TOOL,
LABEL_REQUIES_RESTART,
LABEL_PREVIOUS_UNIT,
LABEL_NEXT_UNIT,
LABEL_SELECTOR_MOVEMENT,
LABEL_REFRESHING_MATCHES,
LABEL_MATCH_FORFEIT,
LABEL_CLEAR_SLOT,
LABEL_WORKSHOP_CLEAR_MAP,
LABEL_TOOLTIPS,
LABEL_NO_MORE_MOVES

Sometimes this is not an issue, other times it may break some layouts. Best way to verify is to see if they are significanly longer than their EN counterparts.

Otherwise, thank you for the awesome contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w84death w84death w84death left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xexio @czlowiekimadlo @w84death