Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wiki-Ops #2294

Closed
13 tasks done
salmad3 opened this issue Jul 6, 2021 · 18 comments
Closed
13 tasks done

Wiki-Ops #2294

salmad3 opened this issue Jul 6, 2021 · 18 comments
Assignees
Labels
admin Admin/maintenance tasks docs Related to the docs in general. epic Large body of related issues. P1 - ASAP Update that is needed now.

Comments

@salmad3
Copy link
Contributor

salmad3 commented Jul 6, 2021

Workflows

Version 2

Suggestions

  • Create sub-directories for "docs" instead of having all wiki pages under one directory. (i.e. learn has learn guides, build has build guides, etc.)
  • Need to clean up repo in general - docker related files, configuration files, duplicates, etc.
  • [ ] Doc images could use a name convention and also organized into better sub-directories. I would say this can be revisited, but perhaps not a priority atm.
  • Update README
  • Community engagement and new members would benefit from "good first issues" (a label), such as: Update Glossary Terms  #2298.

Feel free to add/edit/refute and discuss these points.

@salmad3 salmad3 added admin Admin/maintenance tasks docs Related to the docs in general. P1 - ASAP Update that is needed now. labels Jul 6, 2021
@nam-hle
Copy link
Contributor

nam-hle commented Jul 6, 2021

I know it's quite early but removing the old website and kusama-guide folders could be added.
Also, update README.md.

@jakehemmerle
Copy link
Contributor

jakehemmerle commented Jul 12, 2021

Readme says master is also pushed to IPFS by github actions but this doesn't seem correct. Should we add a new action to push new masters to IPFS?

@salmad3
Copy link
Contributor Author

salmad3 commented Jul 12, 2021

There's no CircleCI workflows that still run behind the scenes, right?

@salmad3
Copy link
Contributor Author

salmad3 commented Jul 12, 2021

Whenever anyone gets the chance, can you double check if the links are okay now? I have noticed one thing - when I first access the wiki (any page that is), for a split second it hits "page not found" but redirects.

This also happens until refreshing a few times:
image

@jakehemmerle
Copy link
Contributor

There's no CircleCI workflows that still run behind the scenes, right?

don't think so (no .circleci folder), also couldn't find a login for it.

@salmad3
Copy link
Contributor Author

salmad3 commented Jul 13, 2021

Readme says master is also pushed to IPFS by github actions but this doesn't seem correct. Should we add a new action to push new masters to IPFS?

@jakehemmerle #696

@salmad3
Copy link
Contributor Author

salmad3 commented Jul 14, 2021

Brief update:

  • cleaned up branches
  • there is a branch called v1 that would hold version 1 (& arguably a snapshot of version 2)
  • another branch called wikiops that attempts to address... wikiops:) (merges to master)
  • another branch could then serve as a dev or test for staging

@jakehemmerle
Copy link
Contributor

  • there is a branch called v1 that would hold version 1 (& arguably a snapshot of version 2)

I don't think there is any benefit of sustaining v1 as a separate branch as it just overcomplicates every docs/ edit we make (since we have to open 2 prs; one to merge to v1 and one for v2.) I don't think we should touch anything related to docusaurusv1 yet, but when we do, the only thing we should do it remove it from the repo. With that said, there are higher priority things than removing v1 from the codebase I think we should focus on (translation issues, redirect problems, dev server, etc), as having v1 in the codebase doesn't add any additional overhead to anything.

A general approach could be:
i. wikiops gets merged to master
ii. change wikiops to dev - dev is used for staging/testing
iii. clean up v1

i. what is the point of having wikiops as a seperate branch? it seems to just delay new things getting added to master/dev. As each thing comes up, it should get merged in immediately after approval from team members.
ii. why do we change wikiops to dev instead of just creating a new branch off of master? I think separating dev and prod is important, but a simple master -> deploy to dev server, and prod -> deploy to prod (with rule that the only way things get added to prod is via a PR merging master into prod) should suffice (unless you really want a dev branch, in which case we always merge master into dev and never commit directly on dev just like we would do with master and prod.)

@emresurmeli @DrW3RK can I get your input as well?

@salmad3
Copy link
Contributor Author

salmad3 commented Jul 14, 2021

@jakehemmerle

  • v1 doesn't have to hold any static docs or actual wiki content - just web related files. Up until version 2 is good it can serve as a backup. It's also not being prioritized over other issues.
  • wikiops is just a branch to address some of these issues.
  • Regarding master, prod, dev - my mistake, I wrote it out incorrectly. But I don't think master -> staging -> prod is necessary. What I meant to get at was: staging -> master (prod). dev wasn't the right name, more like qa, which would used for staging. PRs opened against qa -> stage and check, then -> master (acts as prod), and qa would created against master.

@jakehemmerle
Copy link
Contributor

  • v1 doesn't have to hold any static docs or actual wiki content - just web related files. Up until version 2 is good it can serve as a backup. It's also not being prioritized over other issues.

Cool we are on the same page. This was my point; we shouldn't touch v1 or move it out of master until we go to delete it, otherwise if do anything special with it (like removing it from master and keeping it in another branch or anything), and we need to do use it, we can't easily rebase it, we have to deal with all the CICD related overhead to make v1 run and then any structural changes (like doc and config stuff) that would need to get fixed manually

@salmad3
Copy link
Contributor Author

salmad3 commented Jul 15, 2021

You're right. Also realized the wikiops branch idea and trying to outpace updates to master isn't a good idea haha. The motive behind it was to "clean up" the repo, but also because as right now, both versions are submerged together - for instance, updating the README to specify "polkadot2" and "kusama2" instead of "polkadot" and "kusama", respectively, because of both being accounted for in the package.json, doesn't seem reasonable

@jakehemmerle
Copy link
Contributor

jakehemmerle commented Jul 15, 2021

@DannyS03 I agree that naming should be consistant; what do you say we swap out polkadot for polkadot1 and polkadot2 for polkadot? That would mainly just be the package.json file and the CICD actions right?

@salmad3
Copy link
Contributor Author

salmad3 commented Jul 15, 2021

That sounds good. Right those should only be the things to update

@salmad3
Copy link
Contributor Author

salmad3 commented Aug 3, 2021

Folder structure should be prioritized: #2415 (comment)

@salmad3 salmad3 mentioned this issue Aug 3, 2021
@salmad3
Copy link
Contributor Author

salmad3 commented Aug 10, 2021

@nam-hle #2442 (comment), any suggestions would be much appreciated

@salmad3
Copy link
Contributor Author

salmad3 commented Aug 16, 2021

@nam-hle it seems like injections still aren't getting recognized, for instance: https://wiki.polkadot.network/docs/learn-identity

@salmad3 salmad3 pinned this issue Aug 16, 2021
@nam-hle
Copy link
Contributor

nam-hle commented Aug 17, 2021

Hi @DannyS03, as I said before, the Markdown parser misunderstood between our variable underscore and italic one. It can be fixed easily by changing italic underscore to asterisk. But I suggest to use camel convention for our variable to fix the issue permanently. What do you think?

@salmad3 salmad3 unpinned this issue Aug 24, 2021
@salmad3
Copy link
Contributor Author

salmad3 commented Aug 24, 2021

It seems like we've tackled the immediate tasks related to "wikiops" up until this point, where IPFS related tasks has an issue of its own that is tracking progress. Because of recent updates we have encountered redirect conflicts (being warnings more than anything), which is also tracked by more than one issue at the moment.

@salmad3 salmad3 closed this as completed Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Admin/maintenance tasks docs Related to the docs in general. epic Large body of related issues. P1 - ASAP Update that is needed now.
Projects
None yet
Development

No branches or pull requests

3 participants