Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] fix Substrate rustdoc link checker #2308

Merged
merged 1 commit into from
Jul 8, 2021
Merged

[CI] fix Substrate rustdoc link checker #2308

merged 1 commit into from
Jul 8, 2021

Conversation

jakehemmerle
Copy link
Contributor

@jakehemmerle jakehemmerle commented Jul 8, 2021

Don't fail building if the latest Substrate version doesn't have rustdoc links for it. Could be more concise (code was pretty wet to start) but master should only fail now when there are real issues.

@jakehemmerle jakehemmerle force-pushed the ci-test branch 3 times, most recently from c85513b to 125b277 Compare July 8, 2021 20:40
@jakehemmerle jakehemmerle changed the title [DONTMERGE] test ci fix [CI] fix Substrate rustdoc link checker Jul 8, 2021
@jakehemmerle jakehemmerle requested a review from salmad3 July 8, 2021 20:55
@jakehemmerle
Copy link
Contributor Author

jakehemmerle commented Jul 8, 2021

should fix substrate rustdoc link updater in #2294

Copy link
Contributor

@salmad3 salmad3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and LGTM

@jakehemmerle jakehemmerle merged commit 2003ffc into master Jul 8, 2021
@jakehemmerle jakehemmerle deleted the ci-test branch July 8, 2021 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants