Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the prettier bot work on external PRs #944

Closed
lsaether opened this issue Sep 12, 2020 · 1 comment
Closed

Make the prettier bot work on external PRs #944

lsaether opened this issue Sep 12, 2020 · 1 comment
Labels
admin Admin/maintenance tasks P3 - Nice to Have Update that is nice to have. security Pull requests that address a security vulnerability

Comments

@lsaether
Copy link
Contributor

Currently the prettier bot only works on PRs made on branches of this repository and not on forks / external PRs. The reason for this is the bot API key that is not exposed to forks of the repo. If we exposed it to forks, someone could fork the repository and alter the CI commands to print our secret API key. We need to come up with a way to solve this - but it involves some thinking and research.

@lsaether lsaether added P3 - Nice to Have Update that is nice to have. security Pull requests that address a security vulnerability admin Admin/maintenance tasks labels Sep 12, 2020
@salmad3 salmad3 mentioned this issue Jul 13, 2021
13 tasks
@salmad3
Copy link
Contributor

salmad3 commented Aug 9, 2021

As a substitute, we will add pretty-quick as a pre-commit check that is generic.
We can revisit if necessary; please reopen if otherwise.

@salmad3 salmad3 closed this as completed Aug 9, 2021
salmad3 added a commit that referenced this issue Aug 9, 2021
* restructure docs

* update all link paths

* take out v1

* remove deployment file and update readme

* update mirror links and sidebars

* update mirror script to account for different paths

* fix mirroring and redirection

* update links and fixes

* fixes

* dupdate gitignore - build docs

* rUpdate package.json:remove v1; add pretty check on commits, can fix #944

* remove and ignore files

* ran pretty-quick

* Update README.md

* remove 'v2' from naming

* update paths in js

* update paths in index.js

* Update generate-pdf.yml

* updates

* clean up
salmad3 added a commit that referenced this issue Aug 14, 2021
* restructure docs

* update all link paths

* take out v1

* remove deployment file and update readme

* update mirror links and sidebars

* update mirror script to account for different paths

* fix mirroring and redirection

* update links and fixes

* fixes

* dupdate gitignore - build docs

* rUpdate package.json:remove v1; add pretty check on commits, can fix #944

* remove and ignore files

* ran pretty-quick

* Update README.md

* remove 'v2' from naming

* update paths in js

* update paths in index.js

* Update generate-pdf.yml

* updates

* clean up

* [2] Restructure Fixes (2/2) (#2470)

* Update learn-scams.md (#2440)

* clean up and fixes for restructure

* Update package.json

* update injection

* fixes

* trigger ci

Co-authored-by: Aleixo Sánchez <[email protected]>

* fix conflicts

* add slug for redirect to default path /docs/ + updates & edits

* fix file ref

* update paths and edits [kusama guide]

* update mirroring for kusama docs

* remove old mirror script

Co-authored-by: Aleixo Sánchez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Admin/maintenance tasks P3 - Nice to Have Update that is nice to have. security Pull requests that address a security vulnerability
Projects
None yet
Development

No branches or pull requests

3 participants