Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address conversion tool is not working #2415

Closed
laboon opened this issue Aug 2, 2021 · 8 comments · Fixed by #2416, #2424 or #2481
Closed

Address conversion tool is not working #2415

laboon opened this issue Aug 2, 2021 · 8 comments · Fixed by #2416, #2424 or #2481
Assignees

Comments

@laboon
Copy link
Contributor

laboon commented Aug 2, 2021

If you enter an address, it does not change when you select a new network.

https://wiki.polkadot.network/docs/learn-accounts#address-conversion-tools

@DrW3RK DrW3RK self-assigned this Aug 2, 2021
@DrW3RK DrW3RK linked a pull request Aug 2, 2021 that will close this issue
@jakehemmerle
Copy link
Contributor

jakehemmerle commented Aug 3, 2021

After spending about an hour trying to get this to work, I say we scrap it and tell them to redirect to one of the converters we have listed below. Thoughts?

@jakehemmerle
Copy link
Contributor

I think it's related to some static JS rendering differences between docusaurus v1 and v2 (since the script was created by Logan a year ago)

@DrW3RK
Copy link
Member

DrW3RK commented Aug 3, 2021

Screenshot 2021-08-03 at 19 06 00

Needs a deeper look as to why this might be happening

@DrW3RK
Copy link
Member

DrW3RK commented Aug 3, 2021

Yup, indeed this is a migration issue. Not with docusaurus, but with the way we reorganized wiki content folders

https://wiki.polkadot.network/js/custom.js - The js folder is outside the docs folder. Looks like this would break all the pages that are currently using javascript in them

@DrW3RK DrW3RK reopened this Aug 3, 2021
This was referenced Aug 3, 2021
@DrW3RK DrW3RK linked a pull request Aug 9, 2021 that will close this issue
@salmad3
Copy link
Contributor

salmad3 commented Aug 16, 2021

@a-jwc said he would take a crack at this

@salmad3 salmad3 reopened this Aug 16, 2021
@DrW3RK
Copy link
Member

DrW3RK commented Aug 16, 2021

Keep me posted. I can look into this again tomorrow

@DrW3RK
Copy link
Member

DrW3RK commented Aug 17, 2021

Figured out the issue. Just needed to reference to JS files appropriately in config file. Creating a PR and merging it to Master

@DrW3RK DrW3RK linked a pull request Aug 17, 2021 that will close this issue
@DrW3RK
Copy link
Member

DrW3RK commented Aug 17, 2021

image
Made progress with correctly referencing JS files in the latest repo structure, but looks like the address changer JS file itself has an issue. Debugging this is beyond our scope I guess. I will remove the address converter tool from the doc. If anyone wants to debug this, raise a new issue/PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants