Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Merge pull request #2935 from w3c/redefine-codecs" #2999

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Sep 4, 2024

Fixes #2956 for REC update.

This reverts commit dc1fc15, reversing changes made to 3d6e620.

Reason for revert is the changes to [[ReceiveCodecs]] were incompatible.


Preview | Diff

This reverts commit dc1fc15, reversing
changes made to 3d6e620.

Reason for revert is the changes to [[ReceiveCodecs]] were incompatible.
@jan-ivar
Copy link
Member Author

jan-ivar commented Sep 4, 2024

This is not editorial.

This is reverting an amendment, which our amendments system doesn't recognize. The editorial label is a workaround for that.

@jan-ivar
Copy link
Member Author

jan-ivar commented Sep 4, 2024

This should buy us more time to get #2972 right (rebased on this).

@alvestrand
Copy link
Contributor

Seems good to revert and reland. The PR got confused between the sender/receiver attributes and the platform attributes.

@alvestrand alvestrand merged commit c174b64 into w3c:main Sep 12, 2024
3 checks passed
dontcallmedom added a commit to w3c/webrtc-interop-reports that referenced this pull request Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

receiver.getParameters().codecs is broken (regression)
2 participants