Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefine SendCodecs and ReceiveCodecs #2935

Merged
merged 16 commits into from
Feb 23, 2024
Merged

Redefine SendCodecs and ReceiveCodecs #2935

merged 16 commits into from
Feb 23, 2024

Conversation

alvestrand
Copy link
Contributor

@alvestrand alvestrand commented Feb 6, 2024

to contain all supported codecs, revealing only those that are "enabled" at any given time.

Fixes: #2925


Preview | Diff

to contain all supported codecs, revealing only those that are
"enabled" at any given time.

Fixes: #2925
@alvestrand
Copy link
Contributor Author

Not sure "editorial" is correct here. It does document the existing browser behavior that implemented but not announced codecs are revealed when they are specifically asked for. But it unblocks the check.

webrtc.html Outdated Show resolved Hide resolved
webrtc.html Show resolved Hide resolved
webrtc.html Show resolved Hide resolved
webrtc.html Show resolved Hide resolved
@alvestrand
Copy link
Contributor Author

WG discussion on Feb 20, 2024: Looks like an improvement.

@dontcallmedom-bot
Copy link

This issue had an associated resolution in WebRTC February 2024 meeting – 20 February 2024 (Modify the codec description model to ease describing changes #2925 #2935):

RESOLUTION: Bring #2935 for merging to editors meeting

webrtc.html Outdated Show resolved Hide resolved
webrtc.html Outdated Show resolved Hide resolved
@alvestrand
Copy link
Contributor Author

From @jan-ivar : link definition of "enabled" to a dfn so that what it is is defined in one place.

webrtc.html Outdated Show resolved Hide resolved
webrtc.html Outdated Show resolved Hide resolved
@alvestrand
Copy link
Contributor Author

Hoisting the @dontcallmedom flag. Can't figure out how to run respec locally to get the error message that listAmendments is complaining about.

@dontcallmedom
Copy link
Member

FYI: what was missing was the step of 1 of the amendment markup process - adding the id of the changed section to base-rec.html.

@alvestrand alvestrand merged commit dc1fc15 into main Feb 23, 2024
2 checks passed
@alvestrand
Copy link
Contributor Author

Thank you @dontcallmedom ! (and for reminding me of the documentation link!!)

@dontcallmedom
Copy link
Member

are there tests associated with this pull request? I would document them in #2910 (and if not, we should track the need to create them)

@dontcallmedom dontcallmedom deleted the redefine-codecs branch February 26, 2024 13:03
jan-ivar added a commit to jan-ivar/webrtc-pc that referenced this pull request Sep 4, 2024
This reverts commit dc1fc15, reversing
changes made to 3d6e620.

Reason for revert is the changes to [[ReceiveCodecs]] were incompatible.
alvestrand added a commit that referenced this pull request Sep 12, 2024
Revert "Merge pull request #2935 from w3c/redefine-codecs"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modify the codec description model to ease describing changes
6 participants