Separate Send/ReceiveCodecs and NegotiatedCodecs #2972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it unambiguous what to return in RTCRtpSender/Receiver's getParameters() function (null before negotiation, filled in after) Fixes: 2956
Set NegotiatedCodecs only on answers for both senders and receivers.
alvestrand
commented
May 13, 2024
jan-ivar
requested changes
May 15, 2024
jan-ivar
reviewed
May 15, 2024
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 20, 2024
In support of landing this spec PR: w3c/webrtc-pc#2972 Bug: None Change-Id: I698276ccf739a872d791fc0923c2725ec303fbd3
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Jun 20, 2024
In support of landing this spec PR: w3c/webrtc-pc#2972 Bug: None Change-Id: I698276ccf739a872d791fc0923c2725ec303fbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5642762 Commit-Queue: Harald Alvestrand <[email protected]> Reviewed-by: Florent Castelli <[email protected]> Cr-Commit-Position: refs/heads/main@{#1317347}
alvestrand
commented
Jun 20, 2024
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 20, 2024
In support of landing this spec PR: w3c/webrtc-pc#2972 Bug: None Change-Id: I698276ccf739a872d791fc0923c2725ec303fbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5642762 Commit-Queue: Harald Alvestrand <[email protected]> Reviewed-by: Florent Castelli <[email protected]> Cr-Commit-Position: refs/heads/main@{#1317347}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jun 20, 2024
In support of landing this spec PR: w3c/webrtc-pc#2972 Bug: None Change-Id: I698276ccf739a872d791fc0923c2725ec303fbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5642762 Commit-Queue: Harald Alvestrand <[email protected]> Reviewed-by: Florent Castelli <[email protected]> Cr-Commit-Position: refs/heads/main@{#1317347}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Jun 24, 2024
…the right time., a=testonly Automatic update from web-platform-tests Add tests for if codec info surfaces at the right time. In support of landing this spec PR: w3c/webrtc-pc#2972 Bug: None Change-Id: I698276ccf739a872d791fc0923c2725ec303fbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5642762 Commit-Queue: Harald Alvestrand <[email protected]> Reviewed-by: Florent Castelli <[email protected]> Cr-Commit-Position: refs/heads/main@{#1317347} -- wpt-commits: 4d7ec06c827c841bfe9090a92521de6a2fb265cf wpt-pr: 46840
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jun 25, 2024
…the right time., a=testonly Automatic update from web-platform-tests Add tests for if codec info surfaces at the right time. In support of landing this spec PR: w3c/webrtc-pc#2972 Bug: None Change-Id: I698276ccf739a872d791fc0923c2725ec303fbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5642762 Commit-Queue: Harald Alvestrand <[email protected]> Reviewed-by: Florent Castelli <[email protected]> Cr-Commit-Position: refs/heads/main@{#1317347} -- wpt-commits: 4d7ec06c827c841bfe9090a92521de6a2fb265cf wpt-pr: 46840
jamienicol
pushed a commit
to jamienicol/gecko
that referenced
this pull request
Jun 27, 2024
…the right time., a=testonly Automatic update from web-platform-tests Add tests for if codec info surfaces at the right time. In support of landing this spec PR: w3c/webrtc-pc#2972 Bug: None Change-Id: I698276ccf739a872d791fc0923c2725ec303fbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5642762 Commit-Queue: Harald Alvestrand <[email protected]> Reviewed-by: Florent Castelli <[email protected]> Cr-Commit-Position: refs/heads/main@{#1317347} -- wpt-commits: 4d7ec06c827c841bfe9090a92521de6a2fb265cf wpt-pr: 46840
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified-and-comments-removed
that referenced
this pull request
Jul 1, 2024
…the right time., a=testonly Automatic update from web-platform-tests Add tests for if codec info surfaces at the right time. In support of landing this spec PR: w3c/webrtc-pc#2972 Bug: None Change-Id: I698276ccf739a872d791fc0923c2725ec303fbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5642762 Commit-Queue: Harald Alvestrand <htachromium.org> Reviewed-by: Florent Castelli <orphischromium.org> Cr-Commit-Position: refs/heads/main{#1317347} -- wpt-commits: 4d7ec06c827c841bfe9090a92521de6a2fb265cf wpt-pr: 46840 UltraBlame original commit: b98fa37e2e0425dbfe0f272d58e1c9e0486ec712
gecko-dev-updater
pushed a commit
to marco-c/gecko-dev-wordified
that referenced
this pull request
Jul 1, 2024
…the right time., a=testonly Automatic update from web-platform-tests Add tests for if codec info surfaces at the right time. In support of landing this spec PR: w3c/webrtc-pc#2972 Bug: None Change-Id: I698276ccf739a872d791fc0923c2725ec303fbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5642762 Commit-Queue: Harald Alvestrand <htachromium.org> Reviewed-by: Florent Castelli <orphischromium.org> Cr-Commit-Position: refs/heads/main{#1317347} -- wpt-commits: 4d7ec06c827c841bfe9090a92521de6a2fb265cf wpt-pr: 46840 UltraBlame original commit: b98fa37e2e0425dbfe0f272d58e1c9e0486ec712
sadym-chromium
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Jul 18, 2024
In support of landing this spec PR: w3c/webrtc-pc#2972 Bug: None Change-Id: I698276ccf739a872d791fc0923c2725ec303fbd3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5642762 Commit-Queue: Harald Alvestrand <[email protected]> Reviewed-by: Florent Castelli <[email protected]> Cr-Commit-Position: refs/heads/main@{#1317347}
jan-ivar
requested changes
Sep 4, 2024
Comment on lines
+2231
to
2234
| Then, for each of the codecs that <var>description</var> negotiates for sending, execute the following steps: | ||
| <ol> | ||
| <li>Locate the matching codec description in <var>transceiver</var>.{{RTCRtpTransceiver/[[Sender]]}}.{{RTCRtpSender/[[SendCodecs]]}}.</li> | ||
| <li>If the matching codec description is not found, abort these steps.</li> |
There was a problem hiding this comment.
Which steps are aborted here? One of the nested for-loops or sLD/sRD without error? Either seems wrong.
Not failing assumes negotiated codecs is a subset of this client's [[SendCodecs]]. The 1.0 spec didn't have this. It said:
...which, AFAIK meant sender.getParameters().codecs might include remote codecs not found locally, but found in the remote answer, which JSEP seems to allow: "Any currently available media formats that are not present in the current remote description MUST be added after all existing formats."
Why is this new limitation needed?
It's also unclear what constitutes a "matching codec description".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it unambiguous what to return in RTCRtpSender/Receiver's getParameters() function (null before negotiation, filled in after, which corresponds to implementations).
Fixes #2956
Preview | Diff