Skip to content

Conversation

@9romise
Copy link
Contributor

@9romise 9romise commented Nov 28, 2025

No description provided.

@changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2025

⚠️ No Changeset found

Latest commit: 1b3062a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@FloEdelmann FloEdelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, deleting unneeded code always feels good ☺️

@FloEdelmann FloEdelmann requested a review from Copilot December 1, 2025 10:41
Copilot finished reviewing on behalf of FloEdelmann December 1, 2025 10:43
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes unnecessary semver version checks from test files, simplifying the test suite by eliminating conditional test execution based on ESLint and TypeScript parser versions. The changes indicate that the project has moved to minimum supported versions that no longer require these version guards.

  • Removed conditional test execution based on ESLint version checks (e.g., ESLint 5.10.0, 6.4.0, 7.1.0, 7.24.0, 8.28.0, 9.0.0)
  • Removed conditional test execution based on @typescript-eslint/parser version checks (e.g., 4.0.0, 5.0.0)
  • Updated column/line numbers in test error expectations to match de-indented code
  • Maintained necessary semver checks where version-specific behavior is still needed

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.

Show a summary per file
File Description
tests/lib/rules/space-infix-ops.js Removed ESLint version check for message format, now using only the modern parameterized message
tests/lib/rules/space-in-parens.js Removed ESLint 6.4.0 version check and errorMessage wrapper function, using messageId directly
tests/lib/rules/require-default-prop.js Removed @typescript-eslint/parser 4.0.0 version guard for TypeScript interface props test
tests/lib/rules/prop-name-casing.js Removed @typescript-eslint/parser 4.0.0 version guard and updated column numbers for de-indented test case
tests/lib/rules/no-undef-components.js Removed @typescript-eslint/parser 5.0.0 version guard for type-only imports test
tests/lib/rules/no-restricted-props.js Removed @typescript-eslint/parser 4.0.0 version guards for multiple TypeScript test cases and reordered some properties
tests/lib/rules/no-reserved-keys.js Removed @typescript-eslint/parser 4.0.0 version guards for TypeScript reserved keys tests
tests/lib/rules/no-loss-of-precision.js Removed ESLint 7.1.0 version guards and updated column numbers for precision loss tests
tests/lib/rules/no-implicit-coercion.js Removed ESLint 8.28.0 version guard for one test case (kept other necessary version checks)
tests/lib/rules/no-export-in-script-setup.js Simplified version check by removing @typescript-eslint/parser 5.4.0 requirement, keeping only TypeScript 4.5.0+ check
tests/lib/rules/no-boolean-default.js Removed @typescript-eslint/parser 4.0.0 version guards for TypeScript boolean default tests and reordered properties
tests/lib/rules/component-name-in-template-casing.js Removed @typescript-eslint/parser 5.0.0 version guards for type-only imports tests and updated column numbers

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@FloEdelmann FloEdelmann merged commit b609c2b into vuejs:master Dec 1, 2025
21 checks passed
@9romise 9romise deleted the cleanup/semver branch December 1, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants