-
-
Notifications
You must be signed in to change notification settings - Fork 699
test: remove unnecessary semver calls
#2985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
FloEdelmann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, deleting unneeded code always feels good
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR removes unnecessary semver version checks from test files, simplifying the test suite by eliminating conditional test execution based on ESLint and TypeScript parser versions. The changes indicate that the project has moved to minimum supported versions that no longer require these version guards.
- Removed conditional test execution based on ESLint version checks (e.g., ESLint 5.10.0, 6.4.0, 7.1.0, 7.24.0, 8.28.0, 9.0.0)
- Removed conditional test execution based on @typescript-eslint/parser version checks (e.g., 4.0.0, 5.0.0)
- Updated column/line numbers in test error expectations to match de-indented code
- Maintained necessary
semverchecks where version-specific behavior is still needed
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/lib/rules/space-infix-ops.js |
Removed ESLint version check for message format, now using only the modern parameterized message |
tests/lib/rules/space-in-parens.js |
Removed ESLint 6.4.0 version check and errorMessage wrapper function, using messageId directly |
tests/lib/rules/require-default-prop.js |
Removed @typescript-eslint/parser 4.0.0 version guard for TypeScript interface props test |
tests/lib/rules/prop-name-casing.js |
Removed @typescript-eslint/parser 4.0.0 version guard and updated column numbers for de-indented test case |
tests/lib/rules/no-undef-components.js |
Removed @typescript-eslint/parser 5.0.0 version guard for type-only imports test |
tests/lib/rules/no-restricted-props.js |
Removed @typescript-eslint/parser 4.0.0 version guards for multiple TypeScript test cases and reordered some properties |
tests/lib/rules/no-reserved-keys.js |
Removed @typescript-eslint/parser 4.0.0 version guards for TypeScript reserved keys tests |
tests/lib/rules/no-loss-of-precision.js |
Removed ESLint 7.1.0 version guards and updated column numbers for precision loss tests |
tests/lib/rules/no-implicit-coercion.js |
Removed ESLint 8.28.0 version guard for one test case (kept other necessary version checks) |
tests/lib/rules/no-export-in-script-setup.js |
Simplified version check by removing @typescript-eslint/parser 5.4.0 requirement, keeping only TypeScript 4.5.0+ check |
tests/lib/rules/no-boolean-default.js |
Removed @typescript-eslint/parser 4.0.0 version guards for TypeScript boolean default tests and reordered properties |
tests/lib/rules/component-name-in-template-casing.js |
Removed @typescript-eslint/parser 5.0.0 version guards for type-only imports tests and updated column numbers |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.